Duplicated registers in Inverter and StorEdge

[milkotodorov]

The following registers in Inverter class and the ones in StorEdge class are duplicating each other (almost all of them).

Are there any good reasons for that?

[herbi3]

It is a fix to prior to the little endian map

Now there's the little endian map for the items that require it under inverter.

[milkotodorov]

We have in the Inverter class it is a BIG endian and in the StorEdge class it is LITTLE endian. I do not get it.
The registers in the Inverter class (with the BIG endian) require the map of the StorEdge class?

When you change the value of these registers then, which one should be used for the change? The one from the Inverter or from the StorEdge class?

[herbi3]

The StorEdge class isn't needed now, as the registers that require little endian under the Inverter class now have a lookup map which automatically uses little endian for the registers that need it under Inverter class

[milkotodorov]

I see...the StorEdge was like a workaround until there was a way that these registers be part of the Inverter class and now no longer needed.

We have however the 0xe000: export_control_mode, 0xe001: export_control_limit_mode and 0xe002: export_control_site_limit not part of the Inverter class.

Why not make them part of the Inverter class and remove the StorEdge one?

[herbi3]

It looks like they're still there?

[milkotodorov]

These ones: https://github.com/nmakel/solaredge_modbus/blob/master/src/solaredge_modbus/__init__.py#L703-L705 - they are not part of the Inverter class.

[milkotodorov]

Actually they are there, but with different offsets: https://github.com/nmakel/solaredge_modbus/blob/master/src/solaredge_modbus/__init__.py#L555-L557

[milkotodorov]

Then shall we remove the StorEdge class to not cause confusion, when not needed?

[herbi3]

It has zero effect on functionality. You can use either one. It's easier to use the inverter one to call everything at once. This is someone else pull request and ultimately it can be removed should the author be ok with that

[milkotodorov]

Yes, you are right. But maybe it is still better to cleanup the code from unnecessary class, isn't it?

I'll create a PR, that should be very quick.