Remove not needed StorEdge class
#111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `little_endian_registers` structure as it was related to `StorEdge` class.
|
Bad idea to remove this part. This is related to the inverter data, not batteries. StorEdge is for batteries, the batteries are controlled by the inverter. So it is correct in calling inverter.read_all() or whatever value instead and to maintain simplicity. Now you would have to read StorEdge.read_all() at the same time and merge the data after. Suggestion is to remove the StorEdge class. |
milkotodorov
commented
Jan 16, 2025
|
When the next release is planned to be published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove not needed
StorEdgeclass and its relatedlittle_endian_registersstructure as it is related toStorEdgeclass.Issue discussed in #110