Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added create commit API #222

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Added create commit API #222

merged 1 commit into from
Nov 26, 2021

Conversation

db2222
Copy link
Contributor

@db2222 db2222 commented Aug 1, 2021

See https://docs.gitlab.com/ee/api/commits.html#create-a-commit-with-multiple-files-and-actions.

Renamed existing test class from CommitsClientTest to CommitsClientMockedTest as it worked with mocks.
For this new functionality I added Docker tests so it matches the pattern of the other tests.

Please let me know if anything else is needed. Thanks in advance!

Renamed existing test class to have a clear distinction between docker and mocked variant.
@db2222
Copy link
Contributor Author

db2222 commented Aug 3, 2021

@nmklotas @jetersen Could you please take a look at this pull request. This functionality is seemingly wanted by several people, see #171. Furthermore there already was a pull request but it didn't include any tests, see #214. This one has.

Thanks so much in advance :-)

@dicko2
Copy link

dicko2 commented Nov 26, 2021

I really need this feature in the API, can we please merge it?

If there is any changes needed I'm happy to help out

Copy link
Collaborator

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetersen jetersen merged commit 78bb2b8 into nmklotas:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants