Merge pull request #113 from upalatucci/fix-e2etests

fix tests for 4.17 and 4.18
nmstate · Oct 3, 2024 · 237a2a9 · 237a2a9
2 parents 5cecb2b + cb62a95
commit 237a2a9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/cypress/e2e/StatusList.spec.cy.ts b/cypress/e2e/StatusList.spec.cy.ts
@@ -3,7 +3,6 @@ import {
   EXPAND_INTERFACES_LIST_TEST_ID,
   INTERFACE_DRAWER_TEST_ID,
   LLDP_DRAWER_DETAILS_SECTION_TEST_ID,
-  LLDP_ENABLED_FILTER,
   SEARCH_FILTER_DROPDOWN,
 } from '../support/selectors';
 
@@ -105,9 +104,10 @@ describe('NodeNetworkState list', () => {
       cy.get('table').should('contain', nns.metadata.name);
 
       // open filter toolbar
-      cy.get('button').contains('Filter').click();
+      cy.get('button').contains('Filter').click({ force: true });
 
-      cy.get(LLDP_ENABLED_FILTER).check();
+      // filter by lldp enabled
+      cy.contains('label', 'Enabled').find('input[type="checkbox"]').check();
 
       // close filter toolbar by clicking outside
       cy.clickOutside();

diff --git a/cypress/support/selectors.ts b/cypress/support/selectors.ts
@@ -3,7 +3,5 @@ export const EXPAND_INTERFACE_INFO = 'ethernet-expandable-section-toggle';
 export const INTERFACE_DRAWER_TEST_ID = 'interface-drawer';
 export const LLDP_DRAWER_DETAILS_SECTION_TEST_ID = 'lldp-section';
 
-export const LLDP_ENABLED_FILTER = '#enabled [type="checkbox"]';
-
 export const SEARCH_FILTER_DROPDOWN =
   'button.pf-v5-c-dropdown__toggle[data-test-id="dropdown-button"]';