Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31855: fix onChange callback patternfly5 #101

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

upalatucci
Copy link
Collaborator

onChange callback change signature from patternfly 4 to 5.
It has the event first and after the new value

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references Jira Issue OCPBUGS-31855, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

onChange callback change signature from patternfly 4 to 5.
It has the event first and after the new value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@upalatucci
Copy link
Collaborator Author

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references Jira Issue OCPBUGS-31855, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @qiowang721

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: qiowang721.

Note that only nmstate members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@upalatucci: This pull request references Jira Issue OCPBUGS-31855, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @qiowang721

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 552b84c into nmstate:main Apr 8, 2024
3 checks passed
@openshift-ci-robot
Copy link
Collaborator

@upalatucci: Jira Issue OCPBUGS-31855: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31855 has been moved to the MODIFIED state.

In response to this:

onChange callback change signature from patternfly 4 to 5.
It has the event first and after the new value

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants