Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS topology #108

Merged
merged 1 commit into from
Aug 22, 2024
Merged

NNS topology #108

merged 1 commit into from
Aug 22, 2024

Conversation

avivtur
Copy link
Collaborator

@avivtur avivtur commented Aug 8, 2024

Adding a first skeleton to the NNS topology, focusing on:

  1. NNS CR display and it's interfaces
  2. Display green/red border to each interface to represent if the interface is up or down. (if default color appears it means the interface state is unknown)
  3. Opening a details drawer on interface select + fill in details.
  4. Add topology toolbar to toggle between list and graph views
  5. Add filter by node name to see just some of the node.
  6. Adding connecting edges between interfaces.

Enhancements to do/Issues to fix:

  1. When filtering and selecting few nodes, it always put the node in the center which can cause overlapping nodes which is confusing to look at.
  2. Fix single node drag.
  3. Improve interfaces drawer info.

Demo:

NNS-topology-1.mp4

@avivtur avivtur force-pushed the nns-topology branch 10 times, most recently from 6b8fa99 to 38ca5fe Compare August 21, 2024 16:23
moreInfoURL?: string;
};

export const DetailItemHeader: FC<DetailItemHeaderProps> = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why making such a genric component? cant split for 2 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also copied from kubevirt

Signed-off-by: Aviv Turgeman <[email protected]>
Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Collaborator

/remove-lgtm

@openshift-ci openshift-ci bot removed the lgtm label Aug 22, 2024
@upalatucci
Copy link
Collaborator

Reviewed. For me it's great thanks aviv

@openshift-merge-bot openshift-merge-bot bot merged commit 5c2212b into nmstate:main Aug 22, 2024
3 checks passed
@avivtur
Copy link
Collaborator Author

avivtur commented Aug 22, 2024

@pcbailey @metalice
PR was merged by accident, please review, leave comments here and will do a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants