Add tests for state list drawer #47
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
upalatucci
force-pushed
the
state-drawer-test
branch
from
a8252b6
to
6fbe0b6
Compare
There was a problem hiding this comment.
Hi @upalatucci
I'd suggest adding a config to have a similar prop like we have in the kubevirt-plugin data-test-id and assigning the components you want to get with unique id's, that should improve readability on this test and will make our future lives easier :)
upalatucci
force-pushed
the
state-drawer-test
branch
2 times, most recently
from
bd31ba2
to
d99bbfa
Compare
|
thanks @avivtur fixed |
cypress/e2e/StatusList.spec.cy.ts
Outdated
| @@ -0,0 +1,41 @@ | |||
| const EXPAND_INTERFACES_LIST_TEST_ID = '#expand-interfaces-list0'; | |||
There was a problem hiding this comment.
It would be cleaner to keep the constants in a separate file.
upalatucci
force-pushed
the
state-drawer-test
branch
from
d99bbfa
to
91563fd
Compare
|
/lgtm |
upalatucci
force-pushed
the
state-drawer-test
branch
from
91563fd
to
790a4d0
Compare
|
/lgtm |
CNV-41292,OCPBUGS-36238: Sync Upstream/Downstream
Add a cypress test to ensure that the nns table works, the interface is clickable and the Drawer opens showing good information.