Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15878: fix radio buttons on policy form #64

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

upalatucci
Copy link
Collaborator

Just fix ids. Patternfly seems to use them to select and deselect elements in the whole form

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references Jira Issue OCPBUGS-15878, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Just fix ids. Patternfly seems to use them to select and deselect elements in the whole form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2023
@upalatucci upalatucci merged commit 92cf6fa into nmstate:main Jul 12, 2023
2 checks passed
@metalice
Copy link
Collaborator

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@metalice: An error was encountered updating to the MODIFIED state for bug OCPBUGS-15878 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Error marking step #28958067 finished: root cause: Tried to update an entity that does not exist.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: Jira Issue OCPBUGS-15878: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15878 has been moved to the MODIFIED state.

In response to this:

Just fix ids. Patternfly seems to use them to select and deselect elements in the whole form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhaozhanqi
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@zhaozhanqi: Jira Issue OCPBUGS-15878 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants