Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-31832: add linux-bridge as filter #73

Merged

Conversation

upalatucci
Copy link
Collaborator

@upalatucci upalatucci commented Aug 11, 2023

  • Add linux-bridge as a filter for the interface types
  • Fix the empty state

Previously the No NodeNetworkStates found was showing up only with no states in the cluster.
Now the message is displayed even when there are no states with the filters selected ( as in all other pages)

Before
image

After

image

Screenshot from 2023-08-11 16-26-54

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 11, 2023

@upalatucci: This pull request references CNV-31832 which is a valid jira issue.

In response to this:

  • Add linux-bridge as a filter for the interface types
  • Fix the empty state

Previously the No NodeNetworkStates found was showing up only with no states in the cluster.
Now the message is displayed even when there are no states with the filters selected ( as in all other pages)

image

Screenshot from 2023-08-11 16-26-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 11, 2023

@upalatucci: This pull request references CNV-31832 which is a valid jira issue.

In response to this:

  • Add linux-bridge as a filter for the interface types
  • Fix the empty state

Previously the No NodeNetworkStates found was showing up only with no states in the cluster.
Now the message is displayed even when there are no states with the filters selected ( as in all other pages)

Before
image

After

image

Screenshot from 2023-08-11 16-26-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one nitpick suggestion. Let me know one your change it or if you disagree with the suggestion and I'll lgtm it.

src/views/states/list/StatesList.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, mostly little improvements or questions ;) otherwise great work, Ugo!

src/views/states/list/StatesList.tsx Show resolved Hide resolved
src/views/states/list/StatesList.tsx Outdated Show resolved Hide resolved
src/views/states/list/StatesList.tsx Outdated Show resolved Hide resolved
@upalatucci upalatucci force-pushed the add-filter-linux-bridge branch 7 times, most recently from c9c145d to 435cc0a Compare August 21, 2023 13:05
@metalice
Copy link
Collaborator

@pcbailey || @hstastna please have another glance

@pcbailey
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 86bc1d8 into nmstate:main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants