-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-31832: add linux-bridge as filter #73
CNV-31832: add linux-bridge as filter #73
Conversation
@upalatucci: This pull request references CNV-31832 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upalatucci: This pull request references CNV-31832 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f12810e
to
ad37a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one nitpick suggestion. Let me know one your change it or if you disagree with the suggestion and I'll lgtm it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, mostly little improvements or questions ;) otherwise great work, Ugo!
c9c145d
to
435cc0a
Compare
435cc0a
to
4d21b4f
Compare
/lgtm |
Previously the
No NodeNetworkStates found
was showing up only with no states in the cluster.Now the message is displayed even when there are no states with the filters selected ( as in all other pages)
Before
After