Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial interface state in nncp form #75

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

upalatucci
Copy link
Collaborator

Creating a new interface in the interface form would generate an interface without state.

spec:
  desiredState:
    interfaces:
      - name: brm2       // second created  interface 
        type: linux-bridge
      - name: brm1     // first created  interface 
        type: linux-bridge
      - name: brm0       // initial interface 
        state: up
        type: linux-bridge

It works because probably the default state is 'up' but its not documented so lets just add it explicitly. This behavior can change over time.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 31f1712 into nmstate:main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants