Fix the "center" of CMAES to be 1-dimensional #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed issue: #110 During the initialization of CMAES, the center point of the search was generated not as a vector of length `n`, but as a tensor of shape `(1, n)`. Because of this, the reported "center" solution in the status dictionary also ended up with an unexpected leftmost dimension with size 1. This fix introduces a `squeeze()` operation on the initial center tensor, and also a shape verification, ensuring that the center tensor is 1-dimensional and has a correct length. With these changes, the reported "center" in the status dictionary becomes 1-dimensional.
engintoklu
requested review from
Higgcz,
pliskowski,
flukeskywalker and
NaturalGradient
Higgcz
approved these changes
Aug 2, 2024
flukeskywalker
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue:
#110
During the initialization of CMAES, the center point of the search was generated not as a vector of length
n, but as a tensor of shape(1, n). Because of this, the reported "center" solution in the status dictionary also ended up with an unexpected leftmost dimension with size 1.This fix introduces a
squeeze()operation on the initial center tensor, and also a shape verification, ensuring that the center tensor is 1-dimensional and has a correct length. With these changes, the reported "center" in the status dictionary becomes 1-dimensional.