Fix wrong defaults of SteadyStateGA #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While initializing `SteadyStateGA`, if the `operators` argument was not given (or was given as an empty list) and if `re_evaluate` was given as True (which is the default), `SteadyStateGA` was making the wrong default assumption that the parent solutions do not have to be evaluated before the children. This wrong assumption caused the tournament selection phases of the cross-over operators to fail, as they encountered unevaluated parents. This commit fixes this wrong assumption. When `operators` is empty (which means that the operators are to be added later via `use(...)` method), and `re_evaluate` is True, then `SteadyStateGA` will by default assume that the parents need to be evaluated first.
engintoklu
requested review from
Higgcz,
pliskowski,
flukeskywalker and
NaturalGradient
Closed
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 77.83% 77.80% -0.04%
==========================================
Files 49 49
Lines 7332 7334 +2
==========================================
- Hits 5707 5706 -1
- Misses 1625 1628 +3
|
NaturalGradient
approved these changes
Sep 13, 2023
Higgcz
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While initializing
SteadyStateGA, if theoperatorsargument was not given (or was given as an empty list) and ifre_evaluatewas given as True (which is the default),SteadyStateGAwas making the wrong default assumption that the parent solutions do not have to be evaluated before the children. This wrong assumption caused the tournament selection phases of the cross-over operators to fail, as they encountered unevaluated parents.This pull request fixes this wrong assumption. When
operatorsis empty (which means that the operators are to be added later viause(...)method), andre_evaluateis True, the default assumption ofSteadyStateGAwill now be that the parents need to be evaluated first.