source in github is directly installable #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohanHart
force-pushed
the
task/installable
branch
from
84f78d6 to
4d9027d
Compare
|
ignore this for now as it seems the the changes to the package to make it work for tsc doesn't work in an angular build |
|
Working but makes the assumption that you'll want to change to publishing from the package root. If not then the gulp copy phases can be added back. That will slightly increase the installed package side but only affects those installing from git. Note that I've not confirmed that the published package works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the package to be installed directly from github.
One downside is that running
npm installinside this package now also runs the build which seems pretty pointless