-
-
Notifications
You must be signed in to change notification settings - Fork 594
doc: add minutes for meeting 2024-12-12 #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# Node.js Release WorkGroup Meeting 2024-12-12 | ||
|
||
## Links | ||
|
||
* **Recording**: https://www.youtube.com/watch?v=xhiA6qJdIu8 | ||
* **GitHub Issue**: https://github.com/nodejs/Release/issues/1064 | ||
* **Minutes Google Doc**: https://docs.google.com/document/d/1DxNxqf85wvd6aVhZeOLif1X6cWYwytlAb3uVos6XpYQ | ||
|
||
## Present | ||
|
||
* Release team: @nodejs/release | ||
* Ruy Adorno @ruyadorno | ||
* Michael Zasso @targos | ||
* Rafael Gonzaga: @RafaelGSS | ||
* Antoine du Hamel @aduh95 | ||
* Richard Lau: @richardlau | ||
|
||
## Announcements | ||
|
||
* Richard: Have added additional tooling to check release assets on R2 staging prior to promotion. | ||
|
||
## Agenda | ||
|
||
### nodejs/node | ||
|
||
* Warning for import assertions [#55873](https://github.com/nodejs/node/pull/55873) | ||
* It can no longer be removed when using the disable warning flag since the warning comes from v8 | ||
|
||
### nodejs/Release | ||
|
||
* create-release-proposal Roadmap [#1061](https://github.com/nodejs/Release/issues/1061) | ||
* Fixed the attribution in the changelog but the commit is still authored by the bot | ||
* Potential to use the automation to also update the staging branch after editing it to remove a commit or change something | ||
* Antoine: I don't think that’s feasible without regressing on the security – currently commits landing on staging branches are signed by a trusted backporter, the automation would be much easier to impersonate. | ||
* Richard: having a shared signing key would require a bigger discussion, it would also be more risky as if it leaks, the whole Release team is compromised – compared to the current situation where, if a releaser private key leaks, it only affects them. | ||
* Backport queue automation PR [#56143](https://github.com/nodejs/node/pull/56143) | ||
* Antoine clarified that the goal is to have it be just an early validation of commits that will land cleanly while getting a report on what commits will need backporting | ||
* `git node staging` node-core-utils command [nodejs/node-core-utils/#875](https://github.com/nodejs/node-core-utils/pull/875) | ||
* Antoine would prefer to have an option for it to be interactive waiting for the releaser to decide on whether to amend the commit and continue or to skip and properly label the original PR with the backport requested label. | ||
* Release plan - v23.x Current [#1045](https://github.com/nodejs/Release/issues/1045) | ||
* Rafael will sign up to cut the next release | ||
* Release plan - v22.x Active LTS [#1001](https://github.com/nodejs/Release/issues/1001) | ||
* Ruy signed up to work on a release early in January | ||
* Release plan - v20.x Maintenance LTS [#855](https://github.com/nodejs/Release/issues/855) | ||
* Michael volunteered to work on the next release | ||
|
||
## Upcoming Meetings | ||
|
||
* **Node.js Project Calendar**: <https://nodejs.org/calendar> | ||
|
||
Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the google docs link seems to be editable by everyone on the internet. Is this intended?