Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Replace var with let #72

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Conversation

lholmquist
Copy link
Contributor

This replaces the usage of var with let to make the code more consistent. This was something i noticed while working on #71

This replaces the usage of var with let to make the code more consistent
@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 58.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          18       18           
  Lines         448      448           
=======================================
  Hits          256      256           
  Misses        192      192
Impacted Files Coverage Δ
lib/format-pretty.js 9.52% <0%> (ø) ⬆️
bin/cmd.js 29.21% <0%> (ø) ⬆️
lib/rules/subsystem.js 100% <100%> (ø) ⬆️
lib/rules/fixes-url.js 96.29% <100%> (ø) ⬆️
lib/rules/metadata-end.js 100% <100%> (ø) ⬆️
lib/rules/pr-url.js 100% <100%> (ø) ⬆️
lib/rules/line-length.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b9053...eb9a963. Read the comment docs.

@joyeecheung joyeecheung merged commit 479fe81 into nodejs:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants