test: Add test for Rule class. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This adds two tests for the Rules class testing the error conditions for when a rule does not have an id parameter or a validate function.
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 57.14% 57.58% +0.44%
==========================================
Files 18 18
Lines 448 448
==========================================
+ Hits 256 258 +2
+ Misses 192 190 -2
Continue to review full report at Codecov.
|
richardlau
reviewed
Aug 2, 2019
lholmquist
force-pushed
the
rules-tests-coverage
branch
from
4c45b9f to
dd5ffe0
Compare
|
i must have renamed the files before i sent the PR, but never closed the the old delete file in my editor, so that showed up in a commit. 🤷♂️ I forced pushed new changes based on the feedback about using tap.throws |
richardlau
approved these changes
Aug 6, 2019
|
Not sure if this one got lost in the flurry of other PR's i sent in :) Just a friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through #73 and #70 I noticed that this class was missing a couple test cases.
This should bring the test coverage up to 100% for that particular file