Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for padding util functions #75

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

lholmquist
Copy link
Contributor

  • This adds tests for both the rightPad and leftPad utility function.

While going through #71 and #70 I noticed that this class was missing a couple test cases.

This should bring the test coverage up to 100% for those particular functions

* This adds tests for both the rightPad and leftPad utility function.
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #75 into master will increase coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   57.14%   58.25%   +1.11%     
==========================================
  Files          18       18              
  Lines         448      448              
==========================================
+ Hits          256      261       +5     
+ Misses        192      187       -5
Impacted Files Coverage Δ
lib/utils.js 74.19% <0%> (+16.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479fe81...f780f73. Read the comment docs.

@Trott Trott merged commit 64a7a65 into nodejs:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants