feat(land): add skipChecks option #475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipChecks will allow skipping certain checks. Useful to skip "commit after last approval" on commit queue. Ref: nodejs/node#34770
|
I'm not 100% sure we're going to use this, but I guess it doesn't hurt to have it either. |
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 82.56% 82.70% +0.13%
==========================================
Files 34 34
Lines 1658 1671 +13
==========================================
+ Hits 1369 1382 +13
Misses 289 289
Continue to review full report at Codecov.
|
codebytere
reviewed
Aug 15, 2020
| @@ -42,6 +45,21 @@ const landOptions = { | |||
| describe: 'Land a backport PR onto a staging branch', | |||
| default: false, | |||
| type: 'boolean' | |||
| }, | |||
| skipChecks: { | |||
There was a problem hiding this comment.
We should add this option to documentation as well, perhaps with an accompanying example :)
|
@mmarchini could you rebase this? |
|
This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skipChecks will allow skipping certain checks. Useful to skip "commit
after last approval" on commit queue.
Ref: nodejs/node#34770