Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git-v8): preserve original author when backporting #872

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 17, 2024

It feels wrong to me to take credit when backporting a V8 commit. I see a reason for not cherry-picking the actual commit instead of creating a new one, so this PR is doing that (with a flag to roll back to the previous behavior).

I'm also adding the -S flag for those who want to selectively sign commits.

@aduh95 aduh95 requested a review from targos November 17, 2024 11:48
@targos
Copy link
Member

targos commented Nov 17, 2024

SGTM for clean cherry-picks (I was reluctant to do it when we had the AUTHORS file). What about backports with conflicts? I feel like we should add a Co-authored-by trailer.

@aduh95
Copy link
Contributor Author

aduh95 commented Nov 19, 2024

@targos LGTY?

@aduh95 aduh95 merged commit 4eaad65 into nodejs:main Nov 19, 2024
10 of 11 checks passed
@aduh95 aduh95 deleted the preserve-authorship branch November 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants