Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use nodejs.org folder a base for --pre-release #874

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

RafaelGSS
Copy link
Member

Fixes: https://github.com/nodejs-private/security-release/issues/15 & https://github.com/nodejs-private/security-release/issues/18

➜  security-release (next-security-release) ../node-core-utils/bin/git-node.js security --pre-release='../nodejs.org'                                                                                            ✱
   ℹ  Current branch: next-security-release
--------------------------------------------------------------------------------
✔ When is the security release going to be announced? Enter in YYYY/MM/DD format: 2024/11/28
   ✔  Announcement file created and banner has been updated. Folder: ../nodejs.org
➜  security-release (next-security-release) cd ../nodejs.org                                                                                                                                                     
➜  nodejs.org (main) git status                                                                                                                                                                                
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   apps/site/site.json

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        apps/site/pages/en/blog/release/november-2024-security-releases.md

no changes added to commit (use "git add" and/or "git commit -a")

Diff:

diff --git a/apps/site/site.json b/apps/site/site.json
index 3ed40c4e..50aa0798 100644
--- a/apps/site/site.json
+++ b/apps/site/site.json
@@ -28,10 +28,10 @@
   ],
   "websiteBanners": {
     "index": {
-      "startDate": "2024-07-08T00:00:00.000Z",
-      "endDate": "2024-07-16T23:59:00.000Z",
-      "text": "July Security Release is available",
-      "link": "https://nodejs.org/en/blog/vulnerability/july-2024-security-releases",
+      "startDate": "2024-11-28T03:00:00.000Z",
+      "endDate": "2024-12-05T03:00:00.000Z",
+      "text": "November Security Release is available",
+      "link": "https://nodejs.org/en/blog/vulnerability/november-2024-security-releases",
       "type": "warning"
     }
   },
@@ -45,4 +45,4 @@
       "link": "https://linuxfoundation.surveymonkey.com/r/nodenext10survey24"
     }
   }
-}
+}
\ No newline at end of file

@RafaelGSS RafaelGSS force-pushed the pre-release-destination-file branch from 713dfd2 to 760f685 Compare November 26, 2024 22:02
@RafaelGSS
Copy link
Member Author

cc: @nodejs/security-release

@RafaelGSS RafaelGSS merged commit 121dfc8 into nodejs:main Nov 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant