[TEMP] For debugging arm ci issue

src/quic/cid.cc

@@ -20,14 +20,12 @@ CID::CID() : ptr_(&cid_) {
 CID::CID(const ngtcp2_cid& cid) : CID(cid.data, cid.datalen) {}
 
 CID::CID(const uint8_t* data, size_t len) : CID() {
-  DCHECK_GE(len, kMinLength);
   DCHECK_LE(len, kMaxLength);
   ngtcp2_cid_init(&cid_, data, len);
 }
 
 CID::CID(const ngtcp2_cid* cid) : ptr_(cid) {
   CHECK_NOT_NULL(cid);
-  DCHECK_GE(cid->datalen, kMinLength);
   DCHECK_LE(cid->datalen, kMaxLength);
 }
 

src/quic/session.cc

@@ -814,6 +814,14 @@ struct Session::Impl final : public MemoryRetainer {
                                                void* user_data,
                                                void* stream_user_data) {
     NGTCP2_CALLBACK_SCOPE(session)
+    // The callback will be invoked with datalen 0 if a zero-length
+    // stream frame with fin flag set is received. In that case, let's
+    // just ignore it.
+    // Per ngtcp2, the range of bytes that are being acknowledged here
+    // are `[offset, offset + datalen]` but we only really care about
+    // the datalen as our accounting does not track the offset and
+    // acknowledges should never come out of order here.
+    if (datalen == 0) return NGTCP2_SUCCESS;
     return session->application().AcknowledgeStreamData(stream_id, datalen)
                ? NGTCP2_SUCCESS
                : NGTCP2_ERR_CALLBACK_FAILURE;

src/quic/streams.cc

@@ -1107,7 +1107,7 @@ void Stream::Acknowledge(size_t datalen) {
   DCHECK_GE(datalen, STAT_GET(Stats, max_offset_ack));
   STAT_SET(Stats, max_offset_ack, datalen);
 
-  // // Consumes the given number of bytes in the buffer.
+  // Consumes the given number of bytes in the buffer.
   outbound_->Acknowledge(datalen);
 }