src: use correct way to signal interceptor error

PR-URL: #54418 Refs: https://github.com/nodejs/node/blob/e4f61de14f8cfb83f1ce0ad1597b86278cd5f5f1/deps/v8/include/v8-function-callback.h#L398-L408 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Cheng Zhao <[email protected]>
nodejs · Aug 25, 2024 · 88d789a · 88d789a
1 parent fe4a92a
commit 88d789a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/node_webstorage.cc b/src/node_webstorage.cc
@@ -572,8 +572,8 @@ static Intercepted StorageSetter(Local<Name> property,
   Storage* storage;
   ASSIGN_OR_RETURN_UNWRAP(&storage, info.This(), Intercepted::kNo);
 
-  if (storage->Store(property, value)) {
-    info.GetReturnValue().Set(value);
+  if (!storage->Store(property, value)) {
+    info.GetReturnValue().SetFalse();
   }
 
   return Intercepted::kYes;