Revert "util: move util._extend to eol" #53429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac97a53.
nodejs-github-bot
added
needs-ci
marco-ippolito
added
dont-land-on-v18.x
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jun 12, 2024
MoLow
approved these changes
Jun 13, 2024
marco-ippolito
added
author ready
jasnell
approved these changes
Jun 14, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in b5aae52 |
targos
added
the
dont-land-on-v22.x
eliphazz
pushed a commit
to eliphazz/node
that referenced
this pull request
Jun 20, 2024
This reverts commit ac97a53. PR-URL: nodejs#53429 Refs: tape-testing/tape#607 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
This reverts commit ac97a53. PR-URL: nodejs#53429 Refs: tape-testing/tape#607 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ac97a53.
Refs: tape-testing/tape#607
It seems
util._extendis used by old versions of debug (< v2.6.7) which is still widely used, so we might want to wait a bit before moving this to EOLCC @mcollina @ljharb