Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.15.0 proposal #53486

Merged
merged 96 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
96 commits
Select commit Hold shift + click to select a range
cd1415c
Revert "crypto: make timingSafeEqual faster for Uint8Array"
tniessen Jun 8, 2024
d02907e
src: remove misplaced windows code under posix guard in node.cc
thisalihassan Apr 15, 2024
6ea72a5
doc: add test_runner to subsystem
rluvaton May 1, 2024
56e19e3
test: drop test-crypto-timing-safe-equal-benchmarks
RafaelGSS May 1, 2024
9587ae9
doc: simplify copy-pasting of `branch-diff` commands
aduh95 May 2, 2024
5161d95
zlib: expose zlib.crc32()
joyeecheung May 2, 2024
739adf9
watch: fix arguments parsing
MoLow May 2, 2024
a5f3dd1
string_decoder: throw an error when writing a too long buffer
kylo5aby Mar 26, 2024
cf817e1
test_runner: preserve hook promise when executed twice
MoLow May 4, 2024
918962d
build: make simdjson a public dep in GN build
zcbenz May 5, 2024
d7eba50
util: improve `isInsideNodeModules`
Uzlopak Mar 21, 2024
8fc52b3
src: fix test local edge case
ShogunPanda Apr 26, 2024
978ee0a
src: only apply fix in main thread
ShogunPanda May 5, 2024
a3b2012
doc: add OpenSSL errors to API docs
j3lamp Jan 27, 2021
0addeb2
test: skip v8-updates/test-linux-perf-logger
targos May 5, 2024
b83fbf8
tools: fix V8 update workflow
aduh95 May 5, 2024
8f8fb91
tools: specify a commit-message for V8 update workflow
aduh95 May 5, 2024
91fadac
doc: make docs more welcoming and descriptive for newcomers
srknzl May 5, 2024
97e0fef
doc: add more definitions to GLOSSARY.md
OnlyAviv May 5, 2024
5215b6f
build, tools: copy release assets to staging R2 bucket once built
flakey5 May 6, 2024
514f01e
tools: use sccache GitHub action
targos May 6, 2024
1dce5de
test: skip some console tests on dumb terminal
AdamMajer May 6, 2024
16ae2b2
buffer: remove lines setting indexes to integer value
kylo5aby May 6, 2024
2246d4f
test: crypto-rsa-dsa testing for dynamic openssl
mhdawson May 1, 2024
121ea13
process: improve event-loop
Uzlopak May 6, 2024
12512c3
doc: add pimterry to collaborators
pimterry May 7, 2024
01eff58
tools: update `gr2m/create-or-update-pull-request-action`
aduh95 May 7, 2024
1be8232
build: drop base64 dep in GN build
zcbenz May 8, 2024
403a4a7
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot May 8, 2024
794e450
console: colorize console error and warn
MrJithil Feb 1, 2024
986bfa2
test: add common.expectRequiredModule()
joyeecheung May 7, 2024
5700600
tools: prepare custom rules for ESLint v9
targos May 9, 2024
3df3e37
doc: add names next to release key bash commands
OnlyAviv May 9, 2024
1ff8f31
watch: enable passthrough ipc in watch mode
znewsham May 9, 2024
2dcbf18
src: avoid unused variable 'error' warning
targos May 10, 2024
dce0300
tools: support != in test status files
joyeecheung Apr 29, 2024
e98c305
tools: support max_virtual_memory test configuration
joyeecheung Apr 29, 2024
9d485b4
tools: fix get_asan_state() in tools/test.py
joyeecheung May 2, 2024
0830b31
tools: fix doc update action
marco-ippolito May 10, 2024
1e429d1
doc: exclude commits with baking-for-lts
marco-ippolito May 10, 2024
6001b16
test: reduce memory usage of test-worker-stdio
AdamMajer May 10, 2024
ae5d47d
doc: watermark string behavior
benjamingr May 10, 2024
4bf3d44
doc: update fs read documentation for clarity
mertcanaltin May 10, 2024
48c15d0
build: remove deprecated calls for argument groups
VoltrexKeyva May 11, 2024
311bdc6
test: add http agent to `executionAsyncResource`
psj-tar-gz Aug 29, 2020
b162aea
src: fix typo Unabled -> Unable
SimonSiefke May 11, 2024
8d628c3
buffer: use size_t instead of uint32_t to avoid segmentation fault
Xstoudi May 11, 2024
585f2a2
doc: update `fs.realpath` documentation
sinkhaha May 11, 2024
184cfe5
benchmark: filter non-present deps from `start-cli-version`
AdamMajer May 11, 2024
7d38c2e
fs: keep fs.promises.readFile read until EOF is reached
kylo5aby May 11, 2024
0638274
test: fix DNS cancel tests
szmarczak May 11, 2024
556e9a2
test: move `test-http-server-request-timeouts-mixed` to sequential
sonimadhuri May 11, 2024
3aa3337
doc: fix `dns.lookup` family `0` and `all` descriptions
domdomegg May 11, 2024
086626f
doc: add examples and notes to http server.close et al
mmarchini May 11, 2024
75dd009
events: replace NodeCustomEvent with CustomEvent
F3n67u May 11, 2024
4102244
test: updated for each to for of in test file
lyannel May 11, 2024
8cb1312
inspector: introduce the `--inspect-wait` flag
cola119 May 11, 2024
d5ab1de
meta: move `@anonrig` to TSC regular member
anonrig May 11, 2024
b774544
deps: enable unbundling of simdjson, simdutf, ada
lemire May 11, 2024
f6290bc
tools: add --certify-safe to nci-ci
mcollina May 12, 2024
74753ed
events: add stop propagation flag to `Event.stopImmediatePropagation`
mikemadest May 12, 2024
0be8123
test: improve coverage of lib/readline.js
pd4d10 May 12, 2024
af27225
doc: add example for `execFileSync` method and ref to stdio
evanshortiss May 12, 2024
4ae4f7e
watch: allow listening for grouped changes
matthieusieben May 12, 2024
eceac78
repl: fix disruptive autocomplete without inspector
Linkgoron May 12, 2024
d08c9a6
test: test pipeline `end` on transform streams
aloisklink Jul 30, 2023
e62c6e2
doc: document pipeline with `end` option
aloisklink Jul 30, 2023
9512839
src: allow preventing debug signal handler start
codebytere May 12, 2024
800b6f6
test: replace `forEach()` in `test-stream-pipe-unpipe-stream`
DevPres May 12, 2024
7603a51
util: fix `%s` format behavior with `Symbol.toPrimitive`
Mar 18, 2024
be309bd
doc: mention push.followTags config
RafaelGSS May 12, 2024
af29120
stream: use `ByteLengthQueuingStrategy` when not in `objectMode`
CGQAQ May 12, 2024
cc74bf7
test: fix broken env fuzzer by initializing process
AdamKorcz May 12, 2024
5fb829b
test: add fuzzer for `ClientHelloParser`
AdamKorcz May 12, 2024
7dda156
test: add fuzzer for native/js string conversion
AdamKorcz Dec 11, 2023
954d2ad
cluster: replace `forEach` with `for-of` loop
jerome-benoit May 12, 2024
033f985
src: use `S_ISDIR` to check if the file is a directory
theanarkh May 12, 2024
972eafd
events: update MaxListenersExceededWarning message log
sinkhaha May 12, 2024
3a1d17a
doc: mention quicker way to build docs
crawford May 12, 2024
1d01325
test: verify request payload is uploaded consistently
awwright May 12, 2024
0fb7c18
crypto: fix duplicated switch-case return values
0o001 May 12, 2024
0513e07
test: use `for-of` instead of `forEach`
gibbyfree May 12, 2024
8b3e83b
buffer: even faster atob
lemire May 12, 2024
227093b
assert: add deep equal check for more Error type
kylo5aby May 12, 2024
0c5e589
test, crypto: use correct object on assert
xicilion May 12, 2024
65fa95d
test: add `Debugger.setInstrumentationBreakpoint` known issue
ulitink May 12, 2024
be9d6f2
url,tools,benchmark: replace deprecated `substr()`
May 12, 2024
89a910b
src: fix Worker termination in `inspector.waitForDebugger`
daeyeon May 13, 2024
2f3f2ff
doc: update hljs with the latest styles
OnlyAviv May 13, 2024
f82d086
path: fix toNamespacedPath on Windows
huseyinacacak-janea May 13, 2024
0289a02
test_runner: fix watch mode race condition
MoLow May 14, 2024
de54123
tools: fix v8-update workflow
targos May 14, 2024
da4dbfc
doc: remove reference to AUTHORS file
marco-ippolito May 14, 2024
d54aa47
test_runner: support test plans
cjihrig May 9, 2024
473fa73
cli: allow running wasm in limited vmem with --disable-wasm-trap-handler
joyeecheung Apr 19, 2024
0bf200b
2024-06-20, Version 20.15.0 'Iron' (LTS)
marco-ippolito Jun 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,10 @@ module.exports = {
selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]',
message: 'Use `new` keyword when throwing an `Error`.',
},
{
selector: "CallExpression[callee.property.name='substr']",
message: 'Use String.prototype.slice() or String.prototype.substring() instead of String.prototype.substr()',
},
{
selector: "CallExpression[callee.name='isNaN']",
message: 'Use Number.isNaN() instead of the global isNaN() function.',
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
persist-credentials: false
- run: ./tools/license-builder.sh # Run the license builder tool
- uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
- uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # v1.9.4
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ jobs:
test-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
env:
CC: sccache gcc
CXX: sccache g++
SCCACHE_GHA_ENABLED: 'true'
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
with:
Expand All @@ -41,6 +45,10 @@ jobs:
uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Set up sccache
uses: mozilla-actions/sccache-action@2e7f9ec7921547d4b46598398ca573513895d0bd # v0.0.4
with:
version: v0.8.0
- name: Environment Information
run: npx envinfo
- name: Build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jobs:
npm ci
NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs)
if [ "$NEW_VERSION" != "" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
echo "NEW_VERSION=new version" >> $GITHUB_ENV
rm -rf package-lock.json node_modules
# Include $NEW_VERSION to explicitly update the package.json
# entry for the dependency and also so that semver-major updates
Expand Down Expand Up @@ -314,7 +314,7 @@ jobs:
if: env.COMMIT_MSG == '' && (github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id)
run: |
echo "COMMIT_MSG=${{ matrix.subsystem }}: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}" >> "$GITHUB_ENV"
- uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
- uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # v1.9.4
if: github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
Expand Down
16 changes: 9 additions & 7 deletions .github/workflows/update-v8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,23 @@ jobs:
node-version: ${{ env.NODE_VERSION }}
- name: Install @node-core/utils
run: npm install -g @node-core/utils
- name: Setup Git config
run: |
git config --global user.name "Node.js GitHub Bot"
git config --global user.email "[email protected]"
- name: Check and download new V8 version
run: |
./tools/dep_updaters/update-v8-patch.sh > temp-output
cat temp-output
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
rm temp-output
- uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
- uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6.0.5
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
author: Node.js GitHub Bot <[email protected]>
body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}.
token: ${{ secrets.GH_USER_TOKEN }}
branch: actions/update-v8-patch # Custom branch *just* for this Action.
labels: v8 engine
delete-branch: true
title: 'deps: patch V8 to ${{ env.NEW_VERSION }}'
update-pull-request-title-and-body: true
body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}.
labels: v8 engine
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V20.md#20.14.0">20.14.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V20.md#20.15.0">20.15.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V20.md#20.14.0">20.14.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V20.md#20.13.1">20.13.1</a><br/>
<a href="doc/changelogs/CHANGELOG_V20.md#20.13.0">20.13.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V20.md#20.12.2">20.12.2</a><br/>
Expand Down
19 changes: 19 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# Contributing to Node.js

Contributions to Node.js include code, documentation, answering user questions,
running the project's infrastructure, and advocating for all types of Node.js
users.

The Node.js project welcomes all contributions from anyone willing to work in
good faith with other contributors and the community. No contribution is too
small and all contributions are valued.

The Node.js project has an open governance model.
Individuals making significant and valuable contributions are made
Collaborators and given commit-access to the project. See the
[GOVERNANCE.md](./GOVERNANCE.md) document for more information about how this
works.

## Contents

* [Code of Conduct](#code-of-conduct)
* [Issues](#issues)
* [Pull Requests](#pull-requests)
Expand All @@ -22,6 +38,9 @@ See [details on our policy on Code of Conduct](./doc/contributing/code-of-conduc

## [Pull Requests](./doc/contributing/pull-requests.md)

Pull Requests are the way concrete changes are made to the code, documentation,
dependencies, and tools contained in the `nodejs/node` repository.

* [Dependencies](./doc/contributing/pull-requests.md#dependencies)
* [Setting up your local environment](./doc/contributing/pull-requests.md#setting-up-your-local-environment)
* [The Process of Making Changes](./doc/contributing/pull-requests.md#the-process-of-making-changes)
Expand Down
24 changes: 21 additions & 3 deletions GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
* [Technical steering committee](#technical-steering-committee)
* [TSC meetings](#tsc-meetings)
* [Collaborator nominations](#collaborator-nominations)
* [Who can nominate Collaborators?](#who-can-nominate-collaborators)
* [Ideal Nominees](#ideal-nominees)
* [Nominating a new Collaborator](#nominating-a-new-collaborator)
* [Onboarding](#onboarding)
* [Consensus seeking process](#consensus-seeking-process)

Expand Down Expand Up @@ -124,11 +127,26 @@ the issue tracker is:

## Collaborator nominations

Existing collaborators can nominate someone to become a collaborator. Nominees
should have significant and valuable contributions across the Node.js
### Who can nominate Collaborators?

Existing Collaborators can nominate someone to become a Collaborator.

### Ideal Nominees

Nominees should have significant and valuable contributions across the Node.js
organization.

To nominate a new collaborator, open an issue in the [nodejs/node][] repository.
Contributions can be:

* Opening pull requests.
* Comments and reviews.
* Opening new issues.
* Participation in other projects, teams, and working groups of the Node.js
organization.

### Nominating a new Collaborator

To nominate a new Collaborator, open an issue in the [nodejs/node][] repository.
Provide a summary of the nominee's contributions. For example:

* Commits in the [nodejs/node][] repository.
Expand Down
11 changes: 11 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ PREFIX ?= /usr/local
FLAKY_TESTS ?= run
TEST_CI_ARGS ?=
STAGINGSERVER ?= node-www
CLOUDFLARE_ENDPOINT ?= https://07be8d2fbc940503ca1be344714cb0d1.r2.cloudflarestorage.com
CLOUDFLARE_BUCKET ?= dist-staging
CLOUDFLARE_PROFILE ?= worker
LOGLEVEL ?= silent
OSTYPE := $(shell uname -s | tr '[:upper:]' '[:lower:]')
ifeq ($(findstring os/390,$OSTYPE),os/390)
Expand Down Expand Up @@ -1160,6 +1163,7 @@ pkg-upload: pkg
ssh $(STAGINGSERVER) "mkdir -p nodejs/$(DISTTYPEDIR)/$(FULLVERSION)"
chmod 664 $(TARNAME).pkg
scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done"

$(TARBALL): release-only doc-only
Expand Down Expand Up @@ -1209,10 +1213,12 @@ tar-upload: tar
ssh $(STAGINGSERVER) "mkdir -p nodejs/$(DISTTYPEDIR)/$(FULLVERSION)"
chmod 664 $(TARNAME).tar.gz
scp -p $(TARNAME).tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.gz
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.gz s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.gz --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.gz.done"
ifeq ($(XZ), 1)
chmod 664 $(TARNAME).tar.xz
scp -p $(TARNAME).tar.xz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.xz
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.xz s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.xz --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).tar.xz.done"
endif

Expand All @@ -1222,6 +1228,7 @@ doc-upload: doc
ssh $(STAGINGSERVER) "mkdir -p nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs/"
chmod -R ug=rw-x+X,o=r+X out/doc/
scp -pr out/doc/* $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs/
ssh $(STAGINGSERVER) "aws s3 cp --recursive nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs/ --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/docs.done"

.PHONY: $(TARBALL)-headers
Expand Down Expand Up @@ -1250,10 +1257,12 @@ tar-headers-upload: tar-headers
ssh $(STAGINGSERVER) "mkdir -p nodejs/$(DISTTYPEDIR)/$(FULLVERSION)"
chmod 664 $(TARNAME)-headers.tar.gz
scp -p $(TARNAME)-headers.tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.gz
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.gz s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.gz --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.gz.done"
ifeq ($(XZ), 1)
chmod 664 $(TARNAME)-headers.tar.xz
scp -p $(TARNAME)-headers.tar.xz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.xz
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.xz s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.xz --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-headers.tar.xz.done"
endif

Expand Down Expand Up @@ -1295,10 +1304,12 @@ binary-upload: binary
ssh $(STAGINGSERVER) "mkdir -p nodejs/$(DISTTYPEDIR)/$(FULLVERSION)"
chmod 664 $(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz
scp -p $(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz.done"
ifeq ($(XZ), 1)
chmod 664 $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz
scp -p $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz
ssh $(STAGINGSERVER) "aws s3 cp nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz s3://$(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz --endpoint=$(CLOUDFLARE_ENDPOINT) --profile=$(CLOUDFLARE_PROFILE)"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz.done"
endif

Expand Down
30 changes: 16 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ For information about the governance of the Node.js project, see

* [aduh95](https://github.com/aduh95) -
**Antoine du Hamel** <<[email protected]>> (he/him)
* [anonrig](https://github.com/anonrig) -
**Yagiz Nizipli** <<[email protected]>> (he/him)
* [apapirovski](https://github.com/apapirovski) -
**Anatoli Papirovski** <<[email protected]>> (he/him)
* [benjamingr](https://github.com/benjamingr) -
Expand Down Expand Up @@ -205,6 +203,8 @@ For information about the governance of the Node.js project, see

#### TSC regular members

* [anonrig](https://github.com/anonrig) -
**Yagiz Nizipli** <<[email protected]>> (he/him)
* [BethGriggs](https://github.com/BethGriggs) -
**Beth Griggs** <<[email protected]>> (she/her)
* [bnoordhuis](https://github.com/bnoordhuis) -
Expand Down Expand Up @@ -411,6 +411,8 @@ For information about the governance of the Node.js project, see
**Claudio Wunder** <<[email protected]>> (he/they)
* [panva](https://github.com/panva) -
**Filip Skokan** <<[email protected]>> (he/him)
* [pimterry](https://github.com/pimterry) -
**Tim Perry** <<[email protected]>> (he/him)
* [Qard](https://github.com/Qard) -
**Stephen Belanger** <<[email protected]>> (he/him)
* [RafaelGSS](https://github.com/RafaelGSS) -
Expand Down Expand Up @@ -771,7 +773,7 @@ Primary GPG keys for Node.js Releasers (some Releasers sign with subkeys):
`8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600`
* **Myles Borins** <<[email protected]>>
`C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8`
* **RafaelGSS** <<[email protected]>>
* **Rafael Gonzaga** <<[email protected]>>
`890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4`
* **Richard Lau** <<[email protected]>>
`C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C`
Expand All @@ -784,17 +786,17 @@ To import the full set of trusted release keys (including subkeys possibly used
to sign releases):

```bash
gpg --keyserver hkps://keys.openpgp.org --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C
gpg --keyserver hkps://keys.openpgp.org --recv-keys 141F07595B7B3FFE74309A937405533BE57C7D57
gpg --keyserver hkps://keys.openpgp.org --recv-keys 74F12602B6F1C4E913FAA37AD3A89613643B6201
gpg --keyserver hkps://keys.openpgp.org --recv-keys DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7
gpg --keyserver hkps://keys.openpgp.org --recv-keys CC68F5A3106FF448322E48ED27F5E38D5B0A215F
gpg --keyserver hkps://keys.openpgp.org --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600
gpg --keyserver hkps://keys.openpgp.org --recv-keys C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8
gpg --keyserver hkps://keys.openpgp.org --recv-keys 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4
gpg --keyserver hkps://keys.openpgp.org --recv-keys C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C
gpg --keyserver hkps://keys.openpgp.org --recv-keys 108F52B48DB57BB0CC439B2997B01419BD92F80A
gpg --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0
gpg --keyserver hkps://keys.openpgp.org --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C # Beth Griggs
gpg --keyserver hkps://keys.openpgp.org --recv-keys 141F07595B7B3FFE74309A937405533BE57C7D57 # Bryan English
gpg --keyserver hkps://keys.openpgp.org --recv-keys 74F12602B6F1C4E913FAA37AD3A89613643B6201 # Danielle Adams
gpg --keyserver hkps://keys.openpgp.org --recv-keys DD792F5973C6DE52C432CBDAC77ABFA00DDBF2B7 # Juan José Arboleda
gpg --keyserver hkps://keys.openpgp.org --recv-keys CC68F5A3106FF448322E48ED27F5E38D5B0A215F # Marco Ippolito
gpg --keyserver hkps://keys.openpgp.org --recv-keys 8FCCA13FEF1D0C2E91008E09770F7A9A5AE15600 # Michaël Zasso
gpg --keyserver hkps://keys.openpgp.org --recv-keys C4F0DFFF4E8C1A8236409D08E73BC641CC11F4C8 # Myles Borins
gpg --keyserver hkps://keys.openpgp.org --recv-keys 890C08DB8579162FEE0DF9DB8BEAB4DFCF555EF4 # Rafael Gonzaga
gpg --keyserver hkps://keys.openpgp.org --recv-keys C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C # Richard Lau
gpg --keyserver hkps://keys.openpgp.org --recv-keys 108F52B48DB57BB0CC439B2997B01419BD92F80A # Ruy Adorno
gpg --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0 # Ulises Gascón
```

See [Verifying binaries](#verifying-binaries) for how to use these keys to
Expand Down
22 changes: 0 additions & 22 deletions benchmark/crypto/timingSafeEqual.js

This file was deleted.

2 changes: 1 addition & 1 deletion benchmark/http/bench-parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function main({ len, n }) {
let header = `GET /hello HTTP/1.1${CRLF}Content-Type: text/plain${CRLF}`;

for (let i = 0; i < len; i++) {
header += `X-Filler${i}: ${Math.random().toString(36).substr(2)}${CRLF}`;
header += `X-Filler${i}: ${Math.random().toString(36).substring(2)}${CRLF}`;
}
header += CRLF;

Expand Down
18 changes: 8 additions & 10 deletions benchmark/misc/startup-cli-version.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,15 @@ const path = require('path');
// tends to be minimal and fewer operations are done to generate
// these so that the startup cost is still dominated by a more
// indispensible part of the CLI.
// NOTE: not all tools are present in tarball hence need to filter
const availableCli = [
'tools/node_modules/eslint/bin/eslint.js',
'deps/npm/bin/npx-cli.js',
'deps/npm/bin/npm-cli.js',
'deps/corepack/dist/corepack.js',
].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli)));
const bench = common.createBenchmark(main, {
cli: [
'tools/node_modules/eslint/bin/eslint.js',
'deps/npm/bin/npx-cli.js',
'deps/npm/bin/npm-cli.js',
'deps/corepack/dist/corepack.js',
],
cli: availableCli,
count: [30],
});

Expand Down Expand Up @@ -47,10 +49,6 @@ function spawnProcess(cli, bench, state) {

function main({ count, cli }) {
cli = path.resolve(__dirname, '../../', cli);
if (!existsSync(cli)) {
return;
}

const warmup = 3;
const state = { count, finished: -warmup };
spawnProcess(cli, bench, state);
Expand Down
Loading