v22.4.0 release proposal #53583
Open
v22.4.0 release proposal #53583
+320,309
−61,423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #53344 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #53343 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #53337 Fixes: #53335 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Feng Yu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
OpenSSL 3 deprecated support for custom engines with a recommendation to switch to its new provider model. PR-URL: #53329 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53352 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #53269 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53349 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #53249 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #53181 Fixes: #53176 Refs: #53176 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Co-authored-by: Robert Nagy <[email protected]> PR-URL: #53261 Fixes: #51930 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #53317 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53235 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.7.1 to 2.8.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@a4aa98b...f086349) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> PR-URL: #53245 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Update the following TLS tests to account for error code changes in OpenSSL 3.2 and later. - `parallel/test-tls-empty-sni-context` - `parallel/test-tls-psk-circuit` PR-URL: #53384 Refs: #53382 Refs: openssl/openssl#19950 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
This puts us closer to what V8 actively supports. GCC is still covered a lot by Jenkins CI. Co-authored-by: Moshe Atlow <[email protected]> PR-URL: #53212 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object. PR-URL: #53292 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53213 Fixes: #51987 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
`node.js` prefix is used for global symbol(`Symbol.for`). So remove `node.js` prefix from `Symbol` usage. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring PR-URL: #53387 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Starting from OpenSSL 3.0.14, 3.1.6, 3.2.2, and 3.3.1, OpenSSL was fixed to return an error reason string for bad/unknown application protocols. Update tests to handle both the old `ECONNRESET` error on older versions of OpenSSL and the new `ERR_SSL_TLSV1_ALERT_NO_APPLICATION_PROTOCOL` on newer versions of OpenSSL. Refs: openssl/openssl#24338 PR-URL: #53373 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #53389 Fixes: #53385 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Kohei Ueno <[email protected]>
Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: #53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #53397 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
With ESLint flat config, we don't need a hack with `node_modules` anymore to load ESLint plugins. This commit moves the node-core plugin out of `tools/node_modules` and creates a new `tools/eslint` directory to store ESLint tools. PR-URL: #53393 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #53396 Fixes: #53035 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #53228 Refs: #52809 Reviewed-By: Michaël Zasso <[email protected]>
Also enable running `make corepack-update` when `node`/`npm` is not available globally. PR-URL: #53405 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fix the bug when copying IPv6 host to a variable to remove brackets. Fixes: #47427 PR-URL: #53400 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This provides a bit more information when V8 runs out of memory. PR-URL: #53360 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Original commit message:
[riscv] Skip check sv57 when enable pointer compress
Change-Id: I4332d3849d113af105630c0e20cd2b5e3deb9392
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5430889
Commit-Queue: Ji Qiu <[email protected]>
Reviewed-by: Ji Qiu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#93244}
Refs: v8/v8@6ea594f
PR-URL: #53412
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot
added
needs-ci
|
Feel free to propose more elaborate descriptions for the notable changes. |
|
@joyeecheung The reproducible snapshot test failed on Windows but this PR does not include 4c730ae |
|
From the logs the Windows failure is likely to be different from the one on the dynamically linked builds, maybe some patches are not backported to v22.x and caused a difference. We can just skip the test on Windows for v22.x. |
|
I just realized this is on 32-bit Windows, which is no longer supported or tested on the main branch |
|
I see, on 32-bit Windows I suspect it's a padding issue - maybe #53563 fixes it? |
Test on https://github.com/targos/node/commits/v22.x-reproducible-snapshot/ (which is v22.x-staging + #53563) https://ci.nodejs.org/job/node-test-commit-windows-fanned/63751/ |
|
It fails as well, unfortunately. |
targos
added a commit
to targos/node
that referenced
this pull request
Jun 26, 2024
Refs: #53583 (comment) PR-URL: #53592 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Notable changes: deps,lib,src: * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435 doc: * move `node --run` stability to rc (Yagiz Nizipli) #53433 * mark WebSocket as stable (Matthew Aitken) #53352 * mark --heap-prof and related flags stable (Joyee Cheung) #53343 * mark --cpu-prof and related flags stable (Joyee Cheung) #53343 * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329 inspector: * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473 lib: * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340 util: * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107 PR-URL: #53583
targos
removed
doc
richardlau
approved these changes
Jun 26, 2024
|
@ljharb I'm seeing |
|
Optimistic release build: https://ci-release.nodejs.org/job/iojs+release/10298/ |
|
It's taking too long (and has random connection failures with the downloads server). I probably won't have time to finish the release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-06-26, Version 22.4.0 (Current), @targos
Notable Changes
Experimental Web Storage API
9e30724b53] - (SEMVER-MINOR) deps,lib,src: add experimental web storage (Colin Ihrig) #52435API stability updates
201266706b] - doc: movenode --runstability to rc (Yagiz Nizipli) #5343316c0884d48] - doc: mark WebSocket as stable (Matthew Aitken) #53352cf375e73c1] - doc: mark --heap-prof and related flags stable (Joyee Cheung) #533430160745057] - doc: mark --cpu-prof and related flags stable (Joyee Cheung) #53343Other Notable Changes
df4762722c] - doc: doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329ad5282e196] - inspector: fix disable async hooks onDebugger.setAsyncCallStackDepth(Joyee Cheung) #53473e95af740fc] - (SEMVER-MINOR) lib: add diagnostics_channel events to module loading (RafaelGSS) #4434050733a1abe] - (SEMVER-MINOR) util: support--no-for argument with boolean type for parseArgs (Zhenwei Jin) #53107Commits
9f32002397] - assert,util: correct comparison when both contain same reference (Daniel Lemire) #53431dfdc062111] - buffer: make indexOf(byte) faster (Tobias Nießen) #534551de437527e] - build: configure with shared sqlite3 (Chengzhong Wu) #53519c7d44ba1f3] - build: find version of Clang installed on Windows (Stefan Stojanovic) #5322836aad8b204] - build: fix spacing before NINJA_ARGS (jakecastelli) #5318182092cdaa3] - crypto: improve GetECGroupBits signature (Tobias Nießen) #53364073c231607] - deps: update c-ares to v1.31.0 (Node.js GitHub Bot) #53554977beab729] - (SEMVER-MINOR) deps: sqlite: fix Windows compilation (Colin Ihrig) #52435e69b8d202c] - deps: update undici to 6.19.2 (Node.js GitHub Bot) #53468c4a7e051c8] - deps: update undici to 6.19.1 (Node.js GitHub Bot) #53468fa34f8fcf0] - deps: update undici to 6.19.1 (Node.js GitHub Bot) #534680b40bfad43] - deps: update undici to 6.19.0 (Node.js GitHub Bot) #534681877f22a79] - deps: update simdjson to 3.9.4 (Node.js GitHub Bot) #534671b84964b8d] - deps: patch V8 to 12.4.254.21 (Node.js GitHub Bot) #534706acadeb59b] - deps: update acorn-walk to 8.3.3 (Node.js GitHub Bot) #534667a7f438841] - deps: update zlib to 1.3.0.1-motley-209717d (Node.js GitHub Bot) #53156bf891bf64c] - deps: update c-ares to v1.30.0 (Node.js GitHub Bot) #53416bd68888261] - deps: V8: cherry-pick a3cc8522a4c8 (kxxt) #534122defaaf771] - deps: V8: cherry-pick 6ea594ff7132 (kxxt) #534129e30724b53] - (SEMVER-MINOR) deps,lib,src: add experimental web storage (Colin Ihrig) #52435608cc05de1] - doc: recommend not using libuv node-api function (Michael Dawson) #5352130858eca59] - doc: add additional guidance for PRs to deps (Michael Dawson) #53499a5852cc710] - doc: only apply content-visibility on all.html (Filip Skokan) #53510befabe5c58] - doc: update the description of the return type for options.filter (Zhenwei Jin) #527425ed1a036ba] - doc: remove first timer badge (Aviv Keller) #53338201266706b] - doc: movenode --runstability to rc (Yagiz Nizipli) #5343346a7681cc4] - doc: add Buffer.from(string) to functions that use buffer pool (Christian Bates-White) #52801ec5364f6de] - doc: add initial text for ambassadors program (Michael Dawson) #52857fa113b8fc7] - doc: fix typo (EhsanKhaki) #53397d9182d0086] - doc: define more cases for stream event emissions (Aviv Keller) #53317923d24b6f2] - doc: remove mentions of policy model from security info (Aviv Keller) #5324948f78cd31b] - doc: fix mistakes in the moduleloadhook api (István Donkó) #5334916c0884d48] - doc: mark WebSocket as stable (Matthew Aitken) #53352df4762722c] - doc: doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329cf375e73c1] - doc: mark --heap-prof and related flags stable (Joyee Cheung) #533430160745057] - doc: mark --cpu-prof and related flags stable (Joyee Cheung) #533436e12d9f049] - doc: remove IRC from man page (Tobias Nießen) #5334424c7a9415b] - doc, http: addrejectNonStandardBodyWritesoption, clear its behaviour (jakecastelli) #53396ec38f3dc6a] - doc, meta: organize contributing to Node-API guide (Aviv Keller) #53243cf5a973c42] - doc, meta: use markdown rather than HTML in CONTRIBUTING.md (Aviv Keller) #53235105b006fd2] - fs: moveToNamespacedPathto c++ (Yagiz Nizipli) #52135568377f7f0] - fs: do not crash if the watched file is removed while setting up watch (Matteo Collina) #53452fad179307c] - fs: add fast api forInternalModuleStat(Yagiz Nizipli) #5134441100b65f6] - http2: reject failed http2.connect when used with promisify (ehsankhfr) #53475ad5282e196] - inspector: fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473b5fc227344] - lib: fix typo in comment (codediverdev) #53543e95af740fc] - (SEMVER-MINOR) lib: add diagnostics_channel events to module loading (RafaelGSS) #44340123910f1de] - lib: remove the unused code (theanarkh) #53463452011b719] - lib: speed up MessageEvent creation internally (Matthew Aitken) #52951710cf7758c] - lib: reduce amount of caught URL errors (Yagiz Nizipli) #5265845b59e58d1] - lib: fix naming convention ofSymbol(Deokjin Kim) #53387515dd24ee7] - lib: fix timer leak (theanarkh) #5333777166137be] - meta: use correct source for workflow in PR (Aviv Keller) #53490d1c10fee53] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #53480a5026386bf] - meta: fix typo in dependency updates (Aviv Keller) #534710b9191da99] - meta: bump step-security/harden-runner from 2.7.1 to 2.8.0 (dependabot[bot]) #5324549cfb9d001] - src: resetprocess.versionsduring pre-execution (Richard Lau) #5344415df4edd22] - src: useargs.This()instead ofHolder(Michaël Zasso) #53474e16a04e852] - src: fix dynamically linked OpenSSL version (Richard Lau) #534565961253824] - src: removebase64fromprocess.versions(Richard Lau) #5344211dd15c0b5] - src: removeSetEncodingfrom StringEncoder (Yagiz Nizipli) #534410c7e69acd2] - src: simplifysize() == 0checks (Yagiz Nizipli) #53440f077afafda] - src: add utilities to help debugging reproducibility of snapshots (Joyee Cheung) #50983004b9ea4c4] - src: make sure that memcpy-ed structs in snapshot have no padding (Joyee Cheung) #50983bfc5236423] - src: return non-empty data in context data serializer (Joyee Cheung) #50983955454ba4d] - src: fix typo in env.cc (EhsanKhaki) #534187d8787768c] - src: avoid strcmp in favor of operator== (Tobias Nießen) #53439599e7c3d8e] - src: remove ArrayBufferAllocator::Reallocate override (Shu-yu Guo) #52910f9075ff38e] - src: print v8::OOMDetails::detail when it's available (Joyee Cheung) #533604704270443] - src: fix IsIPAddress for IPv6 (Hüseyin Açacak) #5340063f62d76de] - src: fix permission inspector crash (theanarkh) #5338970bbc02dac] - src, deps: add nbytes library (James M Snell) #535078b877099d0] - stream: update outdated highwatermark doc (Jay Kim) #53494eded1e9768] - stream: support dispose in writable (Benjamin Gruenbaum) #48547b3372a8b0e] - stream: callback should be called when pendingcb is 0 (jakecastelli) #53438f4efb7f625] - stream: make sure _destroy is called (jakecastelli) #532137dde37591c] - stream: prevent stream unexpected pause when highWaterMark set to 0 (jakecastelli) #532611eebcbf9bf] - test: skip reproducible snapshot test on 32-bit (Michaël Zasso) #5359291b2850303] - test: extend env fortest-node-output-errors(Richard Lau) #53535bcad560726] - test: updatecompressionweb-platform tests (Yagiz Nizipli) #53478b8f436c755] - test: update encoding web-platform tests (Yagiz Nizipli) #53477d2c169a4f6] - test: updateurlweb-platform tests (Yagiz Nizipli) #53472513e6aa4c7] - test: check against run-time OpenSSL version (Richard Lau) #53456602b9d63c4] - test: update tests for OpenSSL 3.0.14 (Richard Lau) #533734a3525bb08] - test: fix test-http-server-keepalive-req-gc (Etienne Pierre-doray) #532927349edb28b] - test: update TLS tests for OpenSSL 3.2 (Richard Lau) #53384a11a05763d] - tls: check result of SSL_CTX_set_*_proto_version (Tobias Nießen) #534594b47f89eb2] - tls: avoid taking ownership of OpenSSL objects (Tobias Nießen) #53436ac8adeb99f] - tls: use SSL_get_peer_tmp_key (Tobias Nießen) #53366d5c380bb09] - tools: lock versions of irrelevant DB deps (Michaël Zasso) #5354671321bb249] - tools: fix skip detection of test runner output (Richard Lau) #53545ca198f4125] - tools: update eslint to 9.5.0 (Node.js GitHub Bot) #5351530fdd482a1] - tools: move ESLint to tools/eslint (Michaël Zasso) #53413fe85e05ba9] - tools: fix c-ares update script (Marco Ippolito) #534148eb7bdf81b] - tools: update lint-md-dependencies (Node.js GitHub Bot) #531589ece63d415] - tools: do not run Corepack code before it's reviewed (Antoine du Hamel) #53405ab2021492b] - tools: move ESLint tools to tools/eslint (Michaël Zasso) #5339378a9037a6d] - tools: use Ubuntu 24.04 and Clang on GitHub actions (Michaël Zasso) #53212855eb25dad] - tools: add stream label on PR when related files being changed in lib (jakecastelli) #5326950733a1abe] - (SEMVER-MINOR) util: support--no-for argument with boolean type for parseArgs (Zhenwei Jin) #53107