worker: allow copied NODE_OPTIONS in the env setting #53596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
legendecas
reviewed
Jun 27, 2024
src/node_worker.cc
Outdated
| USE(env->env_vars()->Get("NODE_OPTIONS").To(&parent_node_options)); | ||
| if (args[1]->IsObject() && | ||
| env_vars->Get("NODE_OPTIONS").To(&node_options) && | ||
| node_options != parent_node_options) { |
There was a problem hiding this comment.
Worker will ignore valid per-env options in NODE_OPTIONS when the process was started with a same NODE_OPTIONS.
#!/usr/bin/env NODE_OPTIONS=--trace-exit ./out/Debug/node
const { Worker, isMainThread } = require('worker_threads')
if (isMainThread) {
new Worker(__filename, {
env: {
NODE_OPTIONS: '--trace-exit'
}
})
} else {
setTimeout(() => {
process.exit(1)
}, 1000)
}There was a problem hiding this comment.
Oh, right, it still needs to be parsed to mutate the per_isolate_opts. Maybe we should just check in the error branch though that do require a pretty dumb error.ends_with("is not allowed in NODE_OPTIONS") check for all the errors..
There was a problem hiding this comment.
..or probably just switch to kDisallowedInEnvvar if the NODE_OPTIONS are character-by-character equal with the parent one
There was a problem hiding this comment.
Updated to just wrap it around a throw-away PerProcessOption and added a test.
joyeecheung
force-pushed
the
worker-option
branch
2 times, most recently
from
fd49c14
to
d60bc23
Compare
When the worker spawning code copies NODE_OPTIONS from process.env, previously we do a check again on the copied NODE_OPTIONS and throw if it contains per-process settings. This can be problematic if the end user starts the process with a NODE_OPTIONS and the worker is spawned by a third-party that tries to extend process.env with some overrides before passing them into the worker. This patch adds another exception that allows the per-process options in the NODE_OPTIONS passed to a worker if the NODE_OPTIONS is character-by-character equal to the parent NODE_OPTIONS. While some more intelligent filter can be useful too, this works good enough for the inheritance case, when the worker spawning code does not intend to modify NODE_OPTIONS.
joyeecheung
force-pushed
the
worker-option
branch
from
d60bc23
to
780ade2
Compare
github-actions
bot
removed
the
request-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the worker spawning code copies NODE_OPTIONS from process.env, previously we do a check again on the copied NODE_OPTIONS and throw if it contains per-process settings. This can be problematic if the end user starts the process with a NODE_OPTIONS and the worker is spawned by a third-party that tries to extend process.env with some overrides before passing them into the worker. This patch adds another exception that skips the validation if the NODE_OPTIONS in the env setting is character-by-character equal to the parent NODE_OPTIONS. While some more intelligent filter can be useful too, this works good enough for the inheritance case, when the worker spawning code does not intend to modify NODE_OPTIONS.
Refs: #41103