Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add toJSON to PerformanceMeasure #53603

Merged
merged 1 commit into from
Jun 29, 2024
Merged

lib: add toJSON to PerformanceMeasure #53603

merged 1 commit into from
Jun 29, 2024

Conversation

theanarkh
Copy link
Contributor

Refs: #53570

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 27, 2024
@theanarkh theanarkh force-pushed the add_toJSON_to_PerformanceMeasure branch from 7bd3cae to 8381fba Compare June 27, 2024 14:57
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59990/

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 27, 2024
@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7771025 into nodejs:main Jun 29, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7771025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@benjamingr benjamingr benjamingr approved these changes

@legendecas legendecas legendecas approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@theanarkh @nodejs-github-bot @benjamingr @anonrig @legendecas @atlowChemi