Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add esm example for os #53604

Merged
merged 1 commit into from
Jun 29, 2024
Merged

doc: add esm example for os #53604

merged 1 commit into from
Jun 29, 2024

Conversation

peixotoleonardo
Copy link
Contributor

This PR add esm example for os module

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Jun 27, 2024
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 27, 2024
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 28, 2024
@RafaelGSS
Copy link
Member

I think you might need to git commit --amend --reset-author after a git config user.name .../git config user.email ....

Your commit author doesn't belong to your GitHub account.

@peixotoleonardo
Copy link
Contributor Author

peixotoleonardo commented Jun 28, 2024 •
edited
Loading

@RafaelGSS done

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit b291605 into nodejs:main Jun 29, 2024
13 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b291605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@H4ad H4ad H4ad approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@peixotoleonardo @RafaelGSS @nodejs-github-bot @lpinca @anonrig @H4ad @legendecas