-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix gyp configs in debug #53605
base: main
Are you sure you want to change the base?
Conversation
Gyp generated build files can be built in either Release/Debug mode. - make: single directory, two configurations by cli: `make -C out BUILDTYPE=Release` and `make -C out BUILDTYPE=Debug`. - msbuild: single directory, two configurations by cli: `msbuild node.sln /p:Configuration=Release` and `msbuild node.sln /p:Configuration=Debug`. - ninja: two directories in `out/`, build with `ninja -C out/Release` or `ninja -C out/Debug`. Variables that changes with either Release or Debug configuration should be defined in a configuration level, instead of the root level. This fixes generating invalid build files. Additionally, `v8_gypfiles/toolchain.gypi` duplicates defines in `v8_gypfiles/features.gypi`. Remove the duplications in `toolchains.gypi`
Review requested:
|
|
configs['Release'][name]= release | ||
configs['Debug'][name]= debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
configs['Release'][name]= release | |
configs['Debug'][name]= debug | |
configs['Release'][name] = release | |
configs['Debug'][name] = debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it doesn't change the fact that ./configure --ninja --debug && make
still builds in Release and Debug modes, right?
Gyp generated build files should be able to be built in either Release/Debug mode.
make -C out BUILDTYPE=Release
andmake -C out BUILDTYPE=Debug
.msbuild node.sln /p:Configuration=Release
andmsbuild node.sln /p:Configuration=Debug
.out/
, build withninja -C out/Release
orninja -C out/Debug
.Variables that changes with either Release or Debug configuration
should be defined in a configuration level, instead of the root level.
Example:
node/common.gypi
Lines 132 to 133 in 8e5d88b
This fixes generating invalid build files.
Additionally,
v8_gypfiles/toolchain.gypi
duplicates defines inv8_gypfiles/features.gypi
. Remove the duplications intoolchains.gypi
Fixes: #53446