doc: fix doc for correct usage with plan & TextContext #53615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
atlowChemi
approved these changes
Jun 28, 2024
|
@Emiltayeb There seems to be a typo |
MoLow
approved these changes
Jun 28, 2024
Fixed section in the doc that describes a test that uses the plan feature in the test-runner. However, the test in this example fails. The fix use (Textcontext) and reduce the plan number to 1 since we have 1 assertion.
Emiltayeb
force-pushed
the
doc-fix-plan-assert
branch
from
bba6285
to
1ca6abb
Compare
Thanks, fixed it :) |
atlowChemi
approved these changes
Jun 28, 2024
atlowChemi
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2e5fc8a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed section in the doc that describes a test that uses the plan feature in the test-runner.
However, the test in this example fails.
The fix use (Textcontext) and reduce the plan number to 1 since we have 1 assertion.