net: validate host name for server listen

[jazelly]

Fixes: #54441

[nodejs-github-bot]

Review requested:

• @nodejs/net

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (e4f61de) to head (9e8f849).
Report is 48 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #54470    +/-   ##
========================================
  Coverage   87.33%   87.33%            
========================================
  Files         648      649     +1     
  Lines      182321   182532   +211     
  Branches    34971    35029    +58     
========================================
+ Hits       159222   159421   +199     
- Misses      16374    16392    +18     
+ Partials     6725     6719     -6     

Files	Coverage Δ
lib/net.js	92.66% <100.00%> (+0.02%)	⬆️

... and 52 files with indirect coverage changes

[jazelly]

PR comments addressed. Seems like this PR is more like validating host with regex. I have added extra test cases to cover the happy paths

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61335/

[mcollina]

lgtm

[mcollina]

I have a rough feeling this might be semver-major. What was the error that was produced before this patch?

[jazelly]

What was the error that was produced before this patch?

before it goes to dns look up and fails there

node:events:497
      throw er; // Unhandled 'error' event
      ^

Error: getaddrinfo ENOTFOUND [::]
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:109:26)
Emitted 'error' event on Server instance at:
    at GetAddrInfoReqWrap.doListen [as callback] (node:net:2132:12)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:109:17) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: '[::]'
}

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61366/

[nodejs-github-bot]

Landed in 52322aa