lib: prefer logical assignment

[RedYetiDev]

Enforces https://eslint.org/docs/latest/rules/logical-assignment-operators

---

IMO logical assignment operators are more concise and readable than if/then and || statements. This way, we can do more in less code, while keeping the files readable.

[codecov]

Codecov Report

Attention: Patch coverage is 97.08738% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.71%. Comparing base (aac8ba7) to head (c46eb6d).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/_http_server.js	75.00%	1 Missing ⚠️
lib/internal/child_process.js	50.00%	0 Missing and 1 partial ⚠️
lib/internal/test_runner/utils.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55044      +/-   ##
==========================================
- Coverage   88.24%   87.71%   -0.54%     
==========================================
  Files         651      651              
  Lines      183856   183775      -81     
  Branches    35853    35462     -391     
==========================================
- Hits       162251   161198    -1053     
- Misses      14896    15824     +928     
- Partials     6709     6753      +44     

Files with missing lines	Coverage Δ
lib/_http_agent.js	98.17% <100.00%> (-0.02%)	⬇️
lib/_http_client.js	97.96% <100.00%> (ø)
lib/_tls_common.js	97.43% <100.00%> (-0.02%)	⬇️
lib/_tls_wrap.js	93.38% <100.00%> (ø)
lib/assert.js	99.87% <100.00%> (ø)
lib/async_hooks.js	99.65% <100.00%> (ø)
lib/child_process.js	97.43% <100.00%> (-0.31%)	⬇️
lib/dgram.js	97.31% <100.00%> (-0.01%)	⬇️
lib/events.js	98.18% <100.00%> (-1.66%)	⬇️
lib/internal/assert.js	100.00% <100.00%> (ø)
... and 32 more

... and 79 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62645/

[anonrig]

This is a cosmetic change, and needs to include an eslint rule in order to land, or someone can easily change it in the future. cc @lpinca

[RedYetiDev]

WIP until I develop a lint rule.

[RedYetiDev]

@anonrig I enforced the logical-assignment-operators lint rule. Are you still blocking?

[anonrig]

74 files is almost impossible to review for me.

[anonrig]

@jasnell @trivikr @atlowChemi please rereview since the changes you approved are no longer the same.

[anonrig]

@RedYetiDev what is the motivation for this change, please add it to your description for reviewers

[RedYetiDev]

@anonrig sorry for the little mistakes in this PR, i hope it's all good now. Thank you so much for your patience (everyone really)

[RedYetiDev]

Okay. This should be A-OK now, could everyone have another look?

[LiviaMedeiros]

LGTM.
For future PRs of this size, I'd recommend to commit fixups separately (i.e. even if rebase is required, it's better to push fixup first and then force-push it rebased on main, so it's easier to review).