Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: pass correct path to DirentFromStats during glob #55071

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fs: pass correct path to DirentFromStats during glob #55071

wants to merge 4 commits into from
+12 −10

Conversation

RedYetiDev
Copy link
Member

Fixes #55060

Passes the dirname as parentPath, rather than the full file path.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 22, 2024
@RedYetiDev RedYetiDev mentioned this pull request Sep 22, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (2cec716) to head (e090d49).
Report is 88 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55071      +/-   ##
==========================================
+ Coverage   88.23%   88.25%   +0.02%     
==========================================
  Files         652      651       -1     
  Lines      183911   183905       -6     
  Branches    35858    35856       -2     
==========================================
+ Hits       162271   162303      +32     
+ Misses      14916    14900      -16     
+ Partials     6724     6702      -22
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.76% <100.00%> (ø)

... and 86 files with indirect coverage changes

@RedYetiDev
Copy link
Member Author

CC @nodejs/fs

@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62723/

@RedYetiDev RedYetiDev added the wip Issues and PRs that are still a work in progress. label Sep 24, 2024
@RedYetiDev
Copy link
Member Author

I need to account for \\ (vs /) on windows.

@RedYetiDev RedYetiDev removed the wip Issues and PRs that are still a work in progress. label Sep 25, 2024
@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62783/

@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@MoLow MoLow MoLow approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The parentPath returned by fsPromises.glob is incorrect in some cases.
6 participants
@RedYetiDev @nodejs-github-bot @MoLow @aduh95 @ZYSzys @VoltrexKeyva