Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: describe the fix for compiling android node.js on an x86_64 host #55133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haotaoyanzhuce
Copy link

@RedYetiDev Sorry, brother, I'm not very familiar with Git, so I created multiple PRs.

from #54995

@RedYetiDev RedYetiDev added the build Issues and PRs related to build files or the CI. label Sep 26, 2024
@haotaoyanzhuce
Copy link
Author

I shortened the commit message because it was too long.

@haotaoyanzhuce
Copy link
Author

@RedYetiDev This PR hasn't had any activity for a while. Is there still an issue? Do you need me to do anything else?

@RedYetiDev RedYetiDev added the review wanted PRs that need reviews. label Oct 9, 2024
@silasol
Copy link

silasol commented Nov 2, 2024

CCX_host is correct? I changge it to CXX_host, and works fine.

        os.environ['CC_host'] = shutil.which('gcc').strip()
        os.environ['CCX_host'] = shutil.which('g++').strip()

my build env info

node version:22.11.0
host : ubuntu  24.02 LTS x86_64
target : android arm64

@haotaoyanzhuce
Copy link
Author

CCX_host is correct? I changge it to CXX_host, and works fine.

        os.environ['CC_host'] = shutil.which('gcc').strip()
        os.environ['CCX_host'] = shutil.which('g++').strip()

my build env info

node version:22.11.0
host : ubuntu  24.02 LTS x86_64
target : android arm64

You're right, I made a mistake here. I'll make the necessary corrections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants