benchmark: add --runs support to run.js #55158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
aduh95
reviewed
Sep 28, 2024
RafaelGSS
added
the
commit-queue-squash
RafaelGSS
force-pushed
the
add-runs-to-benchmark-run
branch
from
af115d3
to
3ae3cf8
Compare
Co-authored-by: Antoine du Hamel <[email protected]>
RafaelGSS
force-pushed
the
add-runs-to-benchmark-run
branch
from
3ae3cf8
to
8bd9e7f
Compare
H4ad
approved these changes
Oct 17, 2024
|
PTAL @H4ad |
RafaelGSS
added
the
author ready
H4ad
reviewed
Oct 18, 2024
| } | ||
| } | ||
|
|
||
| run(); |
There was a problem hiding this comment.
Should we handle a possible rejection of this fn? For any reason
There was a problem hiding this comment.
It's not necessary, it should not 'reject' and if it rejects, the tests will fail.
H4ad
approved these changes
Oct 18, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7c0cc12 |
aduh95
pushed a commit
that referenced
this pull request
Oct 19, 2024
PR-URL: #55158 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55158 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to benchmark/run.js. You can pass the
--runsto define the amount of benchmark suite runs.