lib: avoid excluding symlinks in recursive fs.readdir with filetypes

[juanarbol]

Fixes: #52663

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63415/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (6af5c4e) to head (a8a6aa0).
Report is 55 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55714      +/-   ##
==========================================
+ Coverage   88.41%   88.42%   +0.01%     
==========================================
  Files         654      654              
  Lines      187757   187863     +106     
  Branches    36129    36148      +19     
==========================================
+ Hits       166003   166119     +116     
+ Misses      14997    14982      -15     
- Partials     6757     6762       +5     

Files with missing lines	Coverage Δ
lib/fs.js	98.26% <100.00%> (+0.11%)	⬆️

... and 54 files with indirect coverage changes

[Ethan-Arrowood]

Please add a test; otherwise lgtm

[juanarbol]

Please add a test; otherwise lgtm

Will do

[juanarbol]

@Ethan-Arrowood there we go!

[Ethan-Arrowood]

Are you not missing the recursive: true option here?

[Ethan-Arrowood]

The directory you are creating here would look like:

|- a/
|   |- file
|   | b -> a/

And so I would expect readdirSync('a') to return only 2 items, 'file' and 'b'.

When recursive: true is enabled, what should happen? Would it be infinite?

That infinite behavior is potentially a separate issue.

Can you simplify the link here to maybe do something like:

|- x/
|   |- 1
|   |- 2
|- a/
|   |- 1
|   | b -> x/

And then assert that readdir('a', { recursive: true }) results in 4 entries?

'a/1', 'a/b', 'a/b/1', 'a/b/2'

[Ethan-Arrowood]

Subsequently, it would be great to verify that such a test case currently fails on main, but passes with your changes.

[juanarbol]

Sure, this is main

./node --inspect test/parallel/test-fs-readdir-types-symlinks.js
Debugger listening on ws://127.0.0.1:9229/8079dfce-ab06-46ca-b559-6dc4268378a4
For help, see: https://nodejs.org/en/docs/inspector
[
  Dirent {
    name: '1',
    parentPath: '/Users/juanjose/GitHub/node/test/.tmp.0/b',
    [Symbol(type)]: 1
  },
  Dirent {
    name: 'c',
    parentPath: '/Users/juanjose/GitHub/node/test/.tmp.0/b',
    [Symbol(type)]: 3
  }
]
[ '1', 'c', 'c/1', 'c/2' ]
node:assert:90
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

2 !== 4

And this is w/ this patch

./node --inspect test/parallel/test-fs-readdir-types-symlinks.js
Debugger listening on ws://127.0.0.1:9229/a2e2b4d3-6427-4488-858d-0cda545665ff
For help, see: https://nodejs.org/en/docs/inspector
[
  Dirent {
    name: '1',
    parentPath: '/Users/juanjose/GitHub/node/test/.tmp.0/b',
    [Symbol(type)]: 1
  },
  Dirent {
    name: 'c',
    parentPath: '/Users/juanjose/GitHub/node/test/.tmp.0/b',
    [Symbol(type)]: 3
  },
  Dirent {
    name: '1',
    parentPath: '/Users/juanjose/GitHub/node/test/.tmp.0/b/c',
    [Symbol(type)]: 1
  },
  Dirent {
    name: '2',
    parentPath: '/Users/juanjose/GitHub/node/test/.tmp.0/b/c',
    [Symbol(type)]: 1
  }
]
[ '1', 'c', 'c/1', 'c/2' ]

[juanarbol]

@Ethan-Arrowood you were right, I've addressed your suggestions and tested the thing w/ main branch build.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63608/