fs: deprecate never throw behaviour in fs.existsSync #55753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
richardlau
reviewed
Nov 6, 2024
lib/fs.js
Outdated
| @@ -286,6 +286,7 @@ function existsSync(path) { | |||
| try { | |||
| path = getValidatedPath(path); | |||
| } catch { | |||
| util.deprecate(() => {}, 'never throw on invalid arguments for fs.existsSync is deprecated', 'DEP0186'); | |||
There was a problem hiding this comment.
This means that this is not a documentation-only deprecation.
There was a problem hiding this comment.
Fixed, I think this Runtime, isn't it?
Ceres6
force-pushed
the
chore/deprecate-fs-existSync-never-throw
branch
from
ac72356
to
c3d38fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55753 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 654 654
Lines 187747 187747
Branches 36127 36118 -9
=======================================
+ Hits 165972 165977 +5
- Misses 15009 15014 +5
+ Partials 6766 6756 -10
|
aduh95
added
the
semver-major
aduh95
reviewed
Nov 14, 2024
aduh95
reviewed
Nov 14, 2024
| description: Runtime deprecation. | ||
| --> | ||
|
|
||
| Type: Runtime |
There was a problem hiding this comment.
We should first land it as doc-only
There was a problem hiding this comment.
Should I open a different PR for that?
There was a problem hiding this comment.
You can, we'll need two PRs anyway, you can either keep this one for the runtime and open a new one for the doc-only, or convert this one to be doc-only and open another one for the runtime deprecation later.
Co-authored-by: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to deprecate the behaviour of returning false on argument validation in
fs.existsSynccc @joyeecheung @BridgeAR