Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: remove fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #55862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fs: remove fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #55862

wants to merge 2 commits into from

Conversation

LiviaMedeiros
Copy link
Contributor

Follow-up from: #49686 (runtime deprecation)

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 15, 2024
@LiviaMedeiros LiviaMedeiros added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 15, 2024
@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Nov 15, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 15, 2024

Blocked until the v24.x cutoff

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (b02cd41) to head (82ee7d8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55862      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.01%     
==========================================
  Files         654      654              
  Lines      187852   187804      -48     
  Branches    36134    36130       -4     
==========================================
- Hits       166102   166051      -51     
- Misses      14989    14991       +2     
- Partials     6761     6762       +1
Files with missing lines Coverage Δ
lib/fs.js 98.23% <ø> (-0.03%) ⬇️

... and 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiviaMedeiros @aduh95 @nodejs-github-bot