Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make x509 crypto tests work with BoringSSL #55927

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

codebytere
Copy link
Member

As in title. Tweaks a few checks parallel/test-crypto-x509.js in so they work with BoringSSL

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (1d01ad6) to head (12e14d8).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55927      +/-   ##
==========================================
+ Coverage   88.01%   88.49%   +0.48%     
==========================================
  Files         653      653              
  Lines      187735   187728       -7     
  Branches    35874    36183     +309     
==========================================
+ Hits       165229   166137     +908     
+ Misses      15693    14818     -875     
+ Partials     6813     6773      -40     

see 100 files with indirect coverage changes

---- 🚨 Try these New Features:

@codebytere codebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@nodejs-github-bot

This comment was marked as outdated.

Copy link
Contributor

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regexp without boundaries would allow extraneous symbols before or after the hex value.

test/parallel/test-crypto-x509.js Outdated Show resolved Hide resolved
test/parallel/test-crypto-x509.js Outdated Show resolved Hide resolved
test/parallel/test-crypto-x509.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 21, 2024
@codebytere codebytere added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants