-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make x509 crypto tests work with BoringSSL #55927
Open
codebytere
wants to merge
4
commits into
nodejs:main
Choose a base branch
from
codebytere:upstream-boringssl-x509-compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55927 +/- ##
==========================================
+ Coverage 88.01% 88.49% +0.48%
==========================================
Files 653 653
Lines 187735 187728 -7
Branches 35874 36183 +309
==========================================
+ Hits 165229 166137 +908
+ Misses 15693 14818 -875
+ Partials 6813 6773 -40
|
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 20, 2024
richardlau
approved these changes
Nov 20, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 20, 2024
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regexp without boundaries would allow extraneous symbols before or after the hex value.
Co-authored-by: Livia Medeiros <[email protected]>
Co-authored-by: Livia Medeiros <[email protected]>
Co-authored-by: Livia Medeiros <[email protected]>
LiviaMedeiros
approved these changes
Nov 20, 2024
lpinca
approved these changes
Nov 20, 2024
LiviaMedeiros
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 21, 2024
codebytere
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
needs-ci
PRs that need a full CI run.
labels
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title. Tweaks a few checks
parallel/test-crypto-x509.js
in so they work with BoringSSL