stream: prevent dead lock when Duplex generator is "thrown"

[matthieusieben]

Fixes regression introduced in #55096 and outlined in #56278.

When using a for await loop, v8 (?) might call the .throw function of the iterable instead of the stream handlers (write, final, destroy). This can cause a dead lock as this line waits for a promise that will never be resolved (since the promise is setteled from the stream handlers).

This PR adresses that issue by making sure the promise is resolved whenever the generator's return and throw function are called, preventing the dead lock.

cc @jakecastelli

[nodejs-github-bot]

Review requested:

• @nodejs/streams

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (5ad2ca9) to head (361bc6c).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/streams/duplexify.js	83.33%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56287      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         657      657              
  Lines      190285   190311      +26     
  Branches    36539    36540       +1     
==========================================
+ Hits       168490   168509      +19     
- Misses      14974    14984      +10     
+ Partials     6821     6818       -3     

Files with missing lines	Coverage Δ
lib/internal/streams/duplexify.js	96.00% <83.33%> (-1.17%)	⬇️

... and 38 files with indirect coverage changes

[jakecastelli]

I believe #55096 could potentially cause a massive breakage in the eco-system - as I found out thru some of the user land applications / packages on nightly build. I'd suggest we revert 55096 and open another PR along with the fix in this PR and run a CITGM, so we can be more assured.

Update: actually Robert has added the don't land labels on the PR

cc. @nodejs/streams