src: refactor --trace-env to reuse option selection and handling #56293
+88
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the duplication in the code base, also makes makes the log messages more concise since the `[--trace-env]` prefix should provide enough indication about the fact that it's about environment variable access.
nodejs-github-bot
added
c++
|
cc @nodejs/cpp-reviewers |
github-actions
bot
removed
the
request-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56293 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.02%
==========================================
Files 657 657
Lines 190243 190288 +45
Branches 36536 36527 -9
==========================================
+ Hits 168461 168476 +15
- Misses 14963 14982 +19
- Partials 6819 6830 +11
|
H4ad
approved these changes
Dec 21, 2024
| @@ -9,33 +9,33 @@ const fixtures = require('../common/fixtures'); | |||
| // Check reads from the Node.js internals. | |||
| spawnSyncAndAssert(process.execPath, ['--trace-env', fixtures.path('empty.js')], { | |||
| stderr(output) { | |||
| // This is a non-exhaustive list of the environment variables checked | |||
| // This is a non-exhaustive list of thes checked | |||
There was a problem hiding this comment.
thes?
probably
Suggested change
| // This is a non-exhaustive list of thes checked | |
| // This is a non-exhaustive list of the environment variables checked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the duplication in the code base, also makes makes the log messages more concise since the
[--trace-env]prefix should provide enough indication about the fact that it's about environment variable access.