build: fix GN build for ngtcp2 #56300
Closed
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
meixg
approved these changes
Dec 18, 2024
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Dec 19, 2024
lpinca
approved these changes
Dec 19, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56300 ✔ Done loading data for nodejs/node/pull/56300 ----------------------------------- PR info ------------------------------------ Title build: fix GN build for ngtcp2 (#56300) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:deps-ngtcp2 -> nodejs:main Labels needs-ci, quic Commits 1 - build: fix GN build for ngtcp2 Committers 1 - Cheng <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56300 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56300 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 18 Dec 2024 07:19:14 GMT ✔ Approvals: 4 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/56300#pullrequestreview-2511005214 ✔ - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/56300#pullrequestreview-2511349445 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56300#pullrequestreview-2513482205 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56300#pullrequestreview-2514834331 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-12-19T13:49:16Z: https://ci.nodejs.org/job/node-test-pull-request/64122/ - Querying data for job/node-test-pull-request/64122/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12427264536 |
|
The latest CI is green, I am landing this PR manually |
jakecastelli
added
author ready
jakecastelli
pushed a commit
that referenced
this pull request
Dec 22, 2024
PR-URL: #56300 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 31c20f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build failure with GN after merging #56258.