test: remove test-net-write-fully-async-hex-string flaky designation #56365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs@84c2e712ebcd0f32dc0e RefS: nodejs#52959
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56365 +/- ##
==========================================
- Coverage 88.55% 88.55% -0.01%
==========================================
Files 657 657
Lines 190655 190655
Branches 36584 36576 -8
==========================================
- Hits 168838 168827 -11
- Misses 15001 15009 +8
- Partials 6816 6819 +3 |
github-actions
bot
removed
the
request-ci
juanarbol
approved these changes
Dec 28, 2024
juanarbol
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56365 ✔ Done loading data for nodejs/node/pull/56365 ----------------------------------- PR info ------------------------------------ Title test: remove test-net-write-fully-async-hex-string flaky designation (#56365) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:remove/flaky-test-net-write-fully-async-hex-string -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: remove test-net-write-fully-async-hex-string flaky designation Committers 1 - Luigi Pinca <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56365 Refs: https://github.com/nodejs/node/issues/54918 Refs: https://github.com/nodejs/node/commit/84c2e712ebcd0f32dc0e Refs: https://github.com/nodejs/node/pull/52959 Reviewed-By: Juan José Arboleda <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56365 Refs: https://github.com/nodejs/node/issues/54918 Refs: https://github.com/nodejs/node/commit/84c2e712ebcd0f32dc0e Refs: https://github.com/nodejs/node/pull/52959 Reviewed-By: Juan José Arboleda <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 25 Dec 2024 17:35:27 GMT ✔ Approvals: 1 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/56365#pullrequestreview-2524460594 ✘ This PR needs to wait 111 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-12-26T06:10:21Z: https://ci.nodejs.org/job/node-test-pull-request/64214/ - Querying data for job/node-test-pull-request/64214/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12522809872 |
KhafraDev
approved these changes
Dec 28, 2024
KhafraDev
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 38cd81a |
lpinca
deleted the
remove/flaky-test-net-write-fully-async-hex-string
branch
aduh95
pushed a commit
that referenced
this pull request
Jan 2, 2025
The original issue is likely the same as other tests that time out. Refs: #54918 Refs: 84c2e712ebcd0f32dc0e RefS: #52959 PR-URL: #56365 Refs: #52959 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
aduh95
added
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue is likely the same as other tests that time out.
Refs: #54918
Refs: 84c2e712ebcd0f32dc0e
RefS: #52959