-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: move more crypto to ncrypto #56653
Open
jasnell
wants to merge
5
commits into
nodejs:main
Choose a base branch
from
jasnell:jasnell/ncrypto-big-push
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,990
−1,132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Jan 18, 2025
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
2 times, most recently
from
January 19, 2025 00:00
01671fd
to
a6bff3a
Compare
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
from
January 19, 2025 00:10
a6bff3a
to
ac499cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56653 +/- ##
==========================================
+ Coverage 89.19% 89.22% +0.03%
==========================================
Files 662 662
Lines 191830 191693 -137
Branches 36925 36877 -48
==========================================
- Hits 171105 171041 -64
+ Misses 13568 13542 -26
+ Partials 7157 7110 -47
|
anonrig
approved these changes
Jan 19, 2025
mertcanaltin
approved these changes
Jan 19, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even more ncrypto conversion... nearly done with the initial push.. likely one more PR until we'll be ready to move ncrypto off into it's own repo.