Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: move more crypto to ncrypto #56653

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 18, 2025

Even more ncrypto conversion... nearly done with the initial push.. likely one more PR until we'll be ready to move ncrypto off into it's own repo.

@jasnell jasnell requested a review from anonrig January 18, 2025 23:45
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 18, 2025
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2025
@jasnell jasnell force-pushed the jasnell/ncrypto-big-push branch 2 times, most recently from 01671fd to a6bff3a Compare January 19, 2025 00:00
@jasnell jasnell force-pushed the jasnell/ncrypto-big-push branch from a6bff3a to ac499cb Compare January 19, 2025 00:10
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 65.38462% with 207 lines in your changes missing coverage. Please review.

Project coverage is 89.22%. Comparing base (e96072a) to head (ac499cb).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_sig.cc 63.02% 38 Missing and 33 partials ⚠️
src/crypto/crypto_x509.cc 45.91% 23 Missing and 30 partials ⚠️
src/crypto/crypto_rsa.cc 69.62% 5 Missing and 19 partials ⚠️
src/crypto/crypto_hash.cc 70.21% 4 Missing and 10 partials ⚠️
src/crypto/crypto_hmac.cc 75.00% 1 Missing and 7 partials ⚠️
src/crypto/crypto_cipher.cc 75.00% 1 Missing and 5 partials ⚠️
src/crypto/crypto_ec.cc 71.42% 2 Missing and 4 partials ⚠️
src/crypto/crypto_random.cc 50.00% 1 Missing and 4 partials ⚠️
src/crypto/crypto_dsa.cc 63.63% 1 Missing and 3 partials ⚠️
src/crypto/crypto_util.cc 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56653      +/-   ##
==========================================
+ Coverage   89.19%   89.22%   +0.03%     
==========================================
  Files         662      662              
  Lines      191830   191693     -137     
  Branches    36925    36877      -48     
==========================================
- Hits       171105   171041      -64     
+ Misses      13568    13542      -26     
+ Partials     7157     7110      -47     
Files with missing lines Coverage Δ
src/crypto/crypto_cipher.h 59.34% <ø> (ø)
src/crypto/crypto_common.cc 73.30% <100.00%> (-0.26%) ⬇️
src/crypto/crypto_context.cc 69.22% <100.00%> (-0.12%) ⬇️
src/crypto/crypto_hkdf.cc 65.27% <100.00%> (ø)
src/crypto/crypto_keys.cc 72.09% <100.00%> (-0.06%) ⬇️
src/crypto/crypto_sig.h 66.66% <100.00%> (ø)
src/crypto/crypto_tls.h 86.66% <100.00%> (+2.05%) ⬆️
src/crypto/crypto_keygen.cc 75.60% <50.00%> (ø)
src/crypto/crypto_x509.h 52.94% <50.00%> (ø)
src/crypto/crypto_pbkdf2.cc 68.11% <33.33%> (ø)
... and 13 more

... and 29 files with indirect coverage changes

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants