-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add RafaelGSS as latest sec release stewards #56682
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:add-rafaelgss-stewards
Jan 23, 2025
Merged
doc: add RafaelGSS as latest sec release stewards #56682
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:add-rafaelgss-stewards
Jan 23, 2025
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Jan 21, 2025
Review requested:
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
richardlau
approved these changes
Jan 21, 2025
UlisesGascon
approved these changes
Jan 21, 2025
marco-ippolito
approved these changes
Jan 22, 2025
mcollina
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
marco-ippolito
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 23, 2025
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jan 23, 2025
Commit Queue failed- Loading data for nodejs/node/pull/56682 ✔ Done loading data for nodejs/node/pull/56682 ----------------------------------- PR info ------------------------------------ Title doc: add RafaelGSS as latest sec release stewards (#56682) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:add-rafaelgss-stewards -> nodejs:main Labels doc, fast-track Commits 1 - doc: add RafaelGSS as latest sec release stewards Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56682 Refs: https://github.com/nodejs-private/security-release/pull/41 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56682 Refs: https://github.com/nodejs-private/security-release/pull/41 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Jan 2025 19:03:02 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56682#pullrequestreview-2565493993 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56682#pullrequestreview-2565643296 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56682#pullrequestreview-2566619121 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/56682#pullrequestreview-2569153432 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12926580669 |
marco-ippolito
removed
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Jan 23, 2025
I think it just needs to be rebased |
aduh95
force-pushed
the
add-rafaelgss-stewards
branch
from
January 23, 2025 15:31
c263b41
to
b6c09b4
Compare
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Jan 23, 2025
aduh95
approved these changes
Jan 23, 2025
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 23, 2025
Landed in a1c9c1a |
aduh95
pushed a commit
that referenced
this pull request
Jan 27, 2025
PR-URL: #56682 Refs: nodejs-private/security-release#41 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 30, 2025
PR-URL: #56682 Refs: nodejs-private/security-release#41 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jan 31, 2025
PR-URL: #56682 Refs: nodejs-private/security-release#41 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs-private/security-release/pull/41