Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add RafaelGSS as latest sec release stewards #56682

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 21, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-stewards
  • @nodejs/tsc

Copy link
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 21, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 23, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56682
✔  Done loading data for nodejs/node/pull/56682
----------------------------------- PR info ------------------------------------
Title      doc: add RafaelGSS as latest sec release stewards (#56682)
Author     Rafael Gonzaga <[email protected]> (@RafaelGSS)
Branch     RafaelGSS:add-rafaelgss-stewards -> nodejs:main
Labels     doc, fast-track
Commits    1
 - doc: add RafaelGSS as latest sec release stewards
Committers 1
 - RafaelGSS <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56682
Refs: https://github.com/nodejs-private/security-release/pull/41
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56682
Refs: https://github.com/nodejs-private/security-release/pull/41
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Jan 2025 19:03:02 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56682#pullrequestreview-2565493993
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56682#pullrequestreview-2565643296
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56682#pullrequestreview-2566619121
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/56682#pullrequestreview-2569153432
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12926580669

@marco-ippolito marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 23, 2025
@marco-ippolito
Copy link
Member

I think it just needs to be rebased

@aduh95 aduh95 force-pushed the add-rafaelgss-stewards branch from c263b41 to b6c09b4 Compare January 23, 2025 15:31
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit a1c9c1a into nodejs:main Jan 23, 2025
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a1c9c1a

aduh95 pushed a commit that referenced this pull request Jan 27, 2025
PR-URL: #56682
Refs: nodejs-private/security-release#41
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request Jan 30, 2025
PR-URL: #56682
Refs: nodejs-private/security-release#41
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request Jan 31, 2025
PR-URL: #56682
Refs: nodejs-private/security-release#41
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants