benchmark: update num to n in dgram offset-length #59708
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
num
config withn
to be compatible with then
CLI argument.Since this benchmark doesn’t take too long to run (about 40s), I didn’t change the config.
I ran the benchmarks for comparison, but I’m not sure if using len as [1, 512, 1024] would provide better coverage than [1, 64, 256, 1024]. What do you guys think?
If that makes sense to you, let me know, and I can update it to
[1, 512, 1024]
.This change reduces the execution time from 40s to 30s.
Here’s the output for both configs:
len: [1, 64, 256, 1024]
len: [1,512,1024]
Benchmark Machine Specifications: