Skip to content

tools: add sccache to test-internet workflow #59720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

tools: add sccache to test-internet workflow #59720

merged 3 commits into from
Sep 4, 2025
+7 −2

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 2, 2025

Building node takes forever on that job, adding cache should speed it up.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 2, 2025
targos
targos reviewed Sep 2, 2025
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's still needed but in other workflows we set some env variables to enable it:

node/.github/workflows/test-linux.yml

Lines 31 to 33 in 961554c

CC: sccache clang-19
CXX: sccache clang++-19
SCCACHE_GHA_ENABLED: 'true'

@targos
Copy link
Member

targos commented Sep 2, 2025

What about CC/CXX ?

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2025
@aduh95
Copy link
Contributor Author

aduh95 commented Sep 2, 2025

From 125 minutes down to 12.5 minutes 🚀
image

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit b8fa294 into nodejs:main Sep 4, 2025
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b8fa294

@marco-ippolito marco-ippolito added lts-watch-v20.x PRs that may need to be released in v20.x and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Sep 4, 2025
@aduh95 aduh95 deleted the test-internet-sccache branch September 4, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@MoLow MoLow MoLow approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @targos @lpinca @MoLow @marco-ippolito