Skip to content

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Sep 2, 2025

Otherwise there's no information from the error about what exactly is the invalid URL.

Background: I was debugging https://ci.nodejs.org/job/node-test-binary-windows-js-suites/36647/ and I had no idea why the tests are failing since there's no hint about what the URLs are after they get processed in the loader.

Otherwise there's no information from the error about what exactly
is the invalid URL.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 2, 2025
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (961554c) to head (489b0f9).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/url.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59730      +/-   ##
==========================================
- Coverage   89.93%   89.92%   -0.02%     
==========================================
  Files         667      667              
  Lines      196775   196780       +5     
  Branches    38409    38413       +4     
==========================================
- Hits       176977   176954      -23     
- Misses      12247    12248       +1     
- Partials     7551     7578      +27     
Files with missing lines Coverage Δ
lib/internal/errors.js 97.51% <100.00%> (+<0.01%) ⬆️
lib/internal/url.js 93.33% <50.00%> (+<0.01%) ⬆️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2025
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Sep 4, 2025
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2025
@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8e2b093 into nodejs:main Sep 5, 2025
81 of 82 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8e2b093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants