-
-
Notifications
You must be signed in to change notification settings - Fork 33k
url: add err.input to ERR_INVALID_FILE_URL_PATH #59730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+36
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise there's no information from the error about what exactly is the invalid URL.
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59730 +/- ##
==========================================
- Coverage 89.93% 89.92% -0.02%
==========================================
Files 667 667
Lines 196775 196780 +5
Branches 38409 38413 +4
==========================================
- Hits 176977 176954 -23
- Misses 12247 12248 +1
- Partials 7551 7578 +27
🚀 New features to boost your workflow:
|
anonrig
reviewed
Sep 2, 2025
anonrig
approved these changes
Sep 2, 2025
addaleax
approved these changes
Sep 5, 2025
Landed in 8e2b093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
needs-ci
PRs that need a full CI run.
review wanted
PRs that need reviews.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise there's no information from the error about what exactly is the invalid URL.
Background: I was debugging https://ci.nodejs.org/job/node-test-binary-windows-js-suites/36647/ and I had no idea why the tests are failing since there's no hint about what the URLs are after they get processed in the loader.