2025-09-25, Version 24.9.0 (Current) #59997
Merged
+12,359
−6,867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR-URL: #59808 Refs: https://www.shellcheck.net/wiki/SC2006 Refs: https://www.shellcheck.net/wiki/SC2086 Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #59809 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #59814 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
PR-URL: #59817 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
The source code is available from V8 API and assert can avoid reading the source file from the filesystem and parse the file again. PR-URL: #59751 Reviewed-By: Marco Ippolito <[email protected]>
Map source lines in assert messages with cached source maps. PR-URL: #59751 Reviewed-By: Marco Ippolito <[email protected]>
`v8::Module::IsGraphAsync()` traverses the dependencies to find if they contain TLA each time. `ModuleWrap.hasAsyncGraph` caches the result and exposes the property to JS land so that the presence of the property `module.hasAsyncGraph` can be consistent. This also allows C++ access of cached `hasAsyncGraph`. This merges the `intantiateSync`/`instantiate` and `getNamespaceSync`/`getNamespace` as they are always sync. PR-URL: #59703 Reviewed-By: Joyee Cheung <[email protected]>
V8 does not check this for us, but this is a requirement of the API. PR-URL: #59825 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #59830 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
The description is updated to clarify that dynamic import() is asynchronous, dynamic, and works in both CJS and ESM contexts. The new phrasing also avoids implying it is the only method for loading ES modules in CommonJS. Fixes: #59077 PR-URL: #59224 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs-github-bot
added a commit
that referenced
this pull request
Sep 24, 2025
Notable changes: http: * (SEMVER-MINOR) add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824 sqlite: * (SEMVER-MINOR) cleanup ERM support and export Session class (James M Snell) #58378 * (SEMVER-MINOR) add tagged template (0hm☘️) #58748 src: * (SEMVER-MINOR) add an option to make compile cache portable (Aditi) #58797 worker: * (SEMVER-MINOR) add heap profile API (theanarkh) #59846 PR-URL: #59997
github-actions
bot
added
release
|
Review requested:
|
PR-URL: #59839 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #59753 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Bryan English <[email protected]>
PR-URL: #59836 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]>
This avoids explicit calls to the user-mutable `%Promise.prototype%.catch`, and by association, implicit calls to the user-mutable `%Promise.prototype%.then`. PR-URL: #59841 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
These were intended to mimic simple async functions, but exceptions thrown in the function body would be returned synchronously, not wrapped in a rejected Promise. PR-URL: #59841 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
This offers _some_ resistance to `%Promise.prototype%` pollution. Refs: #59699 PR-URL: #59841 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
PR-URL: #59684 Refs: #59583 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
This overload was only used in one place, in a cold path, and in particular in a place where the compiler would be able to generate the exact same code using just a call to `.size()`. PR-URL: #59826 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
These string keys can generally be assumed to be long-lived. PR-URL: #59826 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
PR-URL: #59851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Pasting input should not trigger any completions and other calculations. This is now handled by just writing the string to the terminal in case the user is pasting. As soon as pasting is done, the completions will be re-enabled. Fixes: #40626 Fixes: #43343 PR-URL: #59857 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
The method returned by the callback is missing the .enabled property. This is added in a consistent way that it also verifies that it's a getter. Fixes: #56676 PR-URL: #59858 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
`util.inspect()` should handle all kinds of input, even if it is not well defined. Throwing is something that is meant to be worked around in all known cases. This fixes issues inspecting objects where accessing the Symbol.toStringTag would cause an error. The symbol is just ignored in that case. Refs: #55539 Refs: #55544 PR-URL: #59860 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
`outgoingMessage.setHeader` and `outgoingMessage.getHeader` section PR-URL: #58189 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #59181 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #59954 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Update sqlite Session to support Symbol.dispose and move the definition of the dispose methods to c++ to close the open TODO PR-URL: #58378 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #59848 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Edy Silva <[email protected]>
Notable changes: http: * (SEMVER-MINOR) add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824 sqlite: * (SEMVER-MINOR) cleanup ERM support and export Session class (James M Snell) #58378 * (SEMVER-MINOR) add tagged template (0hm☘️) #58748 worker: * (SEMVER-MINOR) add heap profile API (theanarkh) #59846 PR-URL: #59997
targos
force-pushed
the
v24.9.0-proposal
branch
from
41613c5 to
31c6e70
Compare
targos
approved these changes
Sep 24, 2025
|
CITGM (this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3639/ |
github-actions
bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x #59997 +/- ##
==========================================
- Coverage 90.03% 89.42% -0.61%
==========================================
Files 661 663 +2
Lines 197565 198291 +726
Branches 38614 38635 +21
==========================================
- Hits 177871 177325 -546
- Misses 12095 13291 +1196
- Partials 7599 7675 +76 🚀 New features to boost your workflow:
|
|
@nodejs/releasers given the results in https://ci.nodejs.org/job/node-test-commit-osx/66924/#showFailuresLink and the current macOS CI issues, do you agree to release with a red macOS CI? |
+1 Those tests have been passed on different OSX environments, so it's reasonable. |
+1 from me |
targos
pushed a commit
that referenced
this pull request
Sep 25, 2025
Notable changes: http: * (SEMVER-MINOR) add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824 sqlite: * (SEMVER-MINOR) cleanup ERM support and export Session class (James M Snell) #58378 * (SEMVER-MINOR) add tagged template (0hm☘️) #58748 worker: * (SEMVER-MINOR) add heap profile API (theanarkh) #59846 PR-URL: #59997
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Sep 25, 2025
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 25, 2025
|
https://nodejs.org/download/release/latest/ is still showing Node.js Will this correct itself or should I open a separate issue? |
|
mmh I'm not sure. It's supposed to happen automatically quickly after the release. @nodejs/web-infra |
It's also my experience that it happens automatically. I don't have access to @nodejs/web-infra so I presume it's a private repo. Please let me know if I should post elsewhere, otherwise I will hang back and wait. Thanks! |
|
Thanks for flagging, GHA runner settings changed, causing the runs to failure on promotion: https://github.com/nodejs/release-cloudflare-worker/actions/runs/18024267556 |
|
@ovflowd Thanks for fixing! Looks good from where I am viewing as well. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-09-25, Version 24.9.0 (Current), @targos
Notable Changes
9b043a9096] - (SEMVER-MINOR) http: add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824a6456ab90a] - (SEMVER-MINOR) sqlite: cleanup ERM support and export Session class (James M Snell) #583785563361d22] - (SEMVER-MINOR) sqlite: add tagged template (0hm☘️) #5874804013ee933] - (SEMVER-MINOR) worker: add heap profile API (theanarkh) #59846Commits
cbec4fd6de] - benchmark: calibrate config dgram multi-buffer (Bruno Rodrigues) #596969a4bbdc3c5] - benchmark: calibrate config cluster/echo.js (Nam Yooseong) #598360b284d86e8] - build: add the missing macro definitions for OpenHarmony (hqzing) #5980443e6e54d66] - build: do not include custom ESLint rules testing in tarball (Antoine du Hamel) #59809039ac19154] - crypto: expose signatureAlgorithm on X509Certificate (Patrick Costa) #59235647c332704] - crypto: usereturn awaitwhen returning Promises from async functions (Renegade334) #598418ed4587cf0] - crypto: use async functions for non-stub Promise-returning functions (Renegade334) #59841bb051c56ef] - crypto: avoid calls topromise.catch()(Renegade334) #5984105e560dd25] - deps: update googletest to 50b8600 (Node.js GitHub Bot) #59955fa40d3a785] - deps: update archs files for openssl-3.5.3 (Node.js GitHub Bot) #599018c85570d18] - deps: upgrade openssl sources to openssl-3.5.3 (Node.js GitHub Bot) #59901b71125664e] - deps: update undici to 7.16.0 (Node.js GitHub Bot) #59830dea5dd7077] - dgram: restore buffer optimization in fixBufferList (Yoo) #59934b0c1e67532] - diagnostics_channel: fix race condition with diagnostics_channel and GC (Ugaitz Urien) #599100b37b594c3] - doc: use "WebAssembly" instead of "Web Assembly" (Tobias Nießen) #599541e723f9c6b] - doc: fix typo in section on microtask order (Tobias Nießen) #59932a28962a85c] - doc: update V8 fast API guidance (René) #58999bd767c5d1b] - doc: add security escalation policy (Ulises Gascón) #598069df91e59e1] - doc: type improvement of filehttp.md(yusheng chen) #58189e4f571680b] - doc: deprecate closingfs.Diron garbage collection (Livia Medeiros) #59839e9cb986fa5] - doc: rephrase dynamic import() description (Nam Yooseong) #59224026d4e33f7] - doc,crypto: update subtle.generateKey and subtle.importKey (Filip Skokan) #598512b2591db52] - esm: make hasAsyncGraph non-enumerable (Joyee Cheung) #59905993f05d323] - fs,win: do not add a second trailing slash in readdir (Gerhard Stöbich) #598477aec53b607] - (SEMVER-MINOR) http: add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #5982483ae6102e7] - http: optimize checkIsHttpToken for short strings (방진혁) #598326695067636] - http,https: handle IPv6 with proxies (Joyee Cheung) #59894c5d910a0a9] - http2: fix allowHttp1+Upgrade, broken by shouldUpgradeCallback (Tim Perry) #59924acada1fb82] - inspector: ensure adequate memory allocation forBinary::toBase64(René) #59870396cc8ec65] - lib: update inspect output format for subclasses (Miguel Marcondes Filho) #59687fed1dac8de] - lib: update isDeepStrictEqual to support options (Miguel Marcondes Filho) #59762d785929fd7] - lib: add source map support for assert messages (Chengzhong Wu) #59751ff13d1d61e] - lib,src: cache ModuleWrap.hasAsyncGraph (Chengzhong Wu) #59703b200cd8470] - lib,src: refactor assert to load error source from memory (Chengzhong Wu) #59751e94c57301b] - meta: add .npmrc with ignore-scripts=true (Joyee Cheung) #59914728472a57b] - module: only put directly require-d ESM into require.cache (Joyee Cheung) #59874be48760b93] - node-api: added SharedArrayBuffer api (Mert Can Altin) #59071f006a14522] - node-api: make napi_delete_reference use node_api_basic_env (Jeetu Suthar) #596840f46c1c3b0] - repl: fix cpu overhead pasting big strings to the REPL (Ruben Bridgewater) #598573eeb7b47ea] - sqlite: fix crash session extension callbacks with workers (Bart Louwers) #598480fe53375ec] - (SEMVER-MINOR) sqlite: cleanup ERM support and export Session class (James M Snell) #583789a3e58a007] - (SEMVER-MINOR) sqlite: add tagged template (0hm☘️) #58748f14ed5ab7b] - src: simplify watchdog instantiations viastd::optional(Anna Henningsen) #59960e330f03f84] - src: update crypto objects to use DictionaryTemplate (James M Snell) #5994269b5607cf4] - src: simplify is_callable by making it a concept (Tobias Nießen) #5816986150f3401] - src: rename private fields to follow naming convention (Moonki Choi) #59923d17f299539] - src: use DictionaryTemplate more in URLPattern (James M Snell) #59892ac784912ac] - src: reduce the nearest parent package JSON cache size (Michael Smith) #59888abecdcb536] - src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings (Moonki Choi) #598912bb152500b] - src: create strings inFIXED_ONE_BYTE_STRINGas internalized (Anna Henningsen) #5982603116a7cd8] - src: removestd::arrayoverload ofFIXED_ONE_BYTE_STRING(Anna Henningsen) #598268a5325d6e3] - src: ensurev8::Eternalis empty before setting it (Anna Henningsen) #59825f0c20ccd81] - src: remove unnecessaryEnvironment::GetCurrent()calls (Moonki Choi) #59814213188e491] - stream: use new AsyncResource instead of bind (Matteo Collina) #59867ce8435b003] - test: testcase demonstrating issue 59541 (Eric Rannaud) #598018f32746142] - test: guard write to proxy client if proxy connection is ended (Joyee Cheung) #597426790093fcb] - tls: load bundled and extra certificates off-thread (Joyee Cheung) #59856f5d3f919d8] - tls: only do off-thread certificate loading on loading tls (Joyee Cheung) #5985687bbaa23a0] - tools: fixtools/make-v8.shfor clang (Richard Lau) #598930d23fd525b] - tools: skip test-internet workflow for draft PRs (Michaël Zasso) #59817e17c73731a] - tools: copyeditbuild-tarball.yml(Antoine du Hamel) #5980897c4e1bac9] - typings: remove unused imports (Nam Yooseong) #598808b29bbca76] - url: replaced slice with at (Mikhail) #591816458867a6b] - url: add type checking to urlToHttpOptions() (simon-id) #597533c62b3886f] - util: inspect objects with throwing Symbol.toStringTag (Ruben Bridgewater) #598606133a82875] - util: fix debuglog.enabled not being present with callback logger (Ruben Bridgewater) #598589347ddddf4] - vm: explain how to share promises between contexts w/ afterEvaluate (Eric Rannaud) #5980144ce971619] - vm: "afterEvaluate", evaluate() return a promise from the outer context (Eric Rannaud) #598016e586a1409] - vm: expose hasTopLevelAwait on SourceTextModule (Chengzhong Wu) #5986549747a58a3] - (SEMVER-MINOR) worker: add heap profile API (theanarkh) #59846b970c0bbc2] - zlib: reduce code duplication (jhofstee) #578109782ca2b1b] - zlib: implement fast path for crc32 (Gürgün Dayıoğlu) #59813