tools: fix inspector_protocol updater #60277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.github/workflows/tools.yml` creates a temp file `temp-output` in the workspace, which fails `git status` clean repo check. Also, the GHA checks out a new branch after the update script. Removes these checks in the `roll.py` to fix its run on the GHA.
legendecas
added
the
fast-track
|
Fast-track has been requested by @legendecas. Please 👍 to approve. |
cjihrig
approved these changes
Oct 16, 2025
jakecastelli
approved these changes
Oct 17, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60277 ✔ Done loading data for nodejs/node/pull/60277 ----------------------------------- PR info ------------------------------------ Title tools: fix inspector_protocol updater (#60277) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:fix-tools-ip -> nodejs:main Labels tools, fast-track Commits 1 - tools: fix inspector_protocol updater Committers 1 - Chengzhong Wu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60277 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60277 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Oct 2025 11:52:36 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60277#pullrequestreview-3344987645 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/60277#pullrequestreview-3348102745 ℹ This PR is being fast-tracked ✘ This PR needs to wait 21 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18595587539 |
legendecas
added
request-ci
github-actions
bot
removed
the
request-ci
UlisesGascon
approved these changes
Oct 18, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 481b9b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github/workflows/tools.ymlcreates a temp filetemp-outputin theworkspace, which fails
git statusclean repo check. Also, the GHAchecks out a new branch after the update script.
Removes these checks in the
roll.pyto fix its run on the GHA.Fixes https://github.com/nodejs/node/actions/runs/18559084187/job/52903496133